Skip to content

Add voxel grid downsampling button to Edit menu - #364

Open
nabeya11 wants to merge 1 commit into
masterfrom
feature/voxel-grid-gui
Open

Add voxel grid downsampling button to Edit menu#364
nabeya11 wants to merge 1 commit into
masterfrom
feature/voxel-grid-gui

Conversation

@nabeya11

@nabeya11 nabeya11 commented Sep 6, 2026

Copy link
Copy Markdown
Member

Adds a GUI for the existing voxel_grid console command to the Edit menu, following the same "Grid input + button" pattern as "Create surface".
The button is labeled "Reduce points" so that the effect is clear for non-engineer users.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@codecov

codecov Bot commented Sep 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.34%. Comparing base (836d903) to head (8bcc2e4).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #364   +/-   ##
=======================================
  Coverage   39.34%   39.34%           
=======================================
  Files           8        8           
  Lines        1426     1426           
=======================================
  Hits          561      561           
  Misses        829      829           
  Partials       36       36           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The UI addition matches existing menu patterns and correctly invokes the existing voxel_grid command without introducing behavioral or structural issues.

Pull request overview

Adds a GUI entry in the Edit fold menu to trigger the existing voxel_grid console command, using the same “grid input + action button” pattern as “Create surface”, and labeling the action as “Reduce points” for clarity.

Changes:

  • Adds a “Grid” numeric input (#voxelGridRes) for voxel grid resolution in the Edit menu.
  • Adds a “Reduce points” button (#voxelGrid) wired to run voxel_grid <res> via pcdeditor.command(...).
File summaries
File Description
pcdeditor.js Adds Edit-menu UI (input + button) and click handler to run voxel_grid with the chosen resolution.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@nabeya11
nabeya11 requested a review from at-wat September 6, 2026 10:47
@nabeya11
nabeya11 marked this pull request as ready for review September 6, 2026 10:48

@at-wat at-wat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants