Skip to content

fix: replace console.log/warn with structured logger #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
selfcontained merged 2 commits into from
Jul 11, 2026
Merged

fix: replace console.log/warn with structured logger #755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45c8916
fix: replace console.log/warn with structured logger in server code
selfcontained Jul 11, 2026
fe00a6b
fix: pass raw err to Pino instead of stringified message
selfcontained Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/server/src/routes/release.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,9 +670,9 @@ export async function registerReleaseRoutes(
}
pendingMigrationManifests = evaluation.pending.map((m) => m.manifest);
} catch (err) {
const message = err instanceof Error ? err.message : String(err);
console.warn(
`[release/assisted/launch] migration evaluation failed for ${body.tag}, falling back to legacy metadata: ${message}`
request.log.warn(
{ tag: body.tag, err },
"Migration evaluation failed, falling back to legacy metadata"
);
}

Expand Down
10 changes: 6 additions & 4 deletions apps/server/src/server/agent-lifecycle-runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,9 @@ export function createAgentLifecycleRuntime(
if (archivingAgentIds.has(agent.id)) {
continue;
}
console.log(
`[reconcile] Agent ${agent.id} (${agent.name}) resuming interrupted archive`
appLog.info(
{ agentId: agent.id, agentName: agent.name },
"Resuming interrupted archive"
);
publishUiEvent({
type: "agent.upsert",
Expand Down Expand Up @@ -136,8 +137,9 @@ export function createAgentLifecycleRuntime(
});
trackArchive(agent.id, archivePromise);
} else {
console.log(
`[reconcile] Agent ${agent.id} (${agent.name}) status corrected to stopped`
appLog.info(
{ agentId: agent.id, agentName: agent.name },
"Agent status corrected to stopped"
);
publishUiEvent({
type: "agent.upsert",
Expand Down
Loading