fix: replace console.log/warn with structured logger#755
Merged
selfcontained merged 2 commits intoJul 11, 2026
Conversation
agent-lifecycle-runtime.ts used console.log for reconciliation messages instead of the injected appLog. release.ts used console.warn for a migration evaluation fallback instead of request.log. Both now use the structured Pino logger for consistent, queryable output. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Let Pino's error serializer preserve stack trace, error type, and nested cause for the migration evaluation fallback warning. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
console.loginagent-lifecycle-runtime.ts(reconciliation messages) withappLog.infousing structured metadata (agentId,agentName)console.warninrelease.ts(migration evaluation fallback) withrequest.log.warnusing structured metadata (tag,err)console.*bypasses log levels, formatting, and transportsWhat qualifies as tech debt
These were the last
console.log/console.warncalls in request-handling server code. The remainingconsole.*calls in the codebase are in startup/config code and standalone migration scripts, which is appropriate since they run before the Fastify logger is initialized.Next run
Unsafe type cast in
apps/web/src/components/app/unified-diff-view.tsx:267—as unknown as MouseEventdouble-cast.🤖 Generated with Claude Code