Repository navigation
ci: cap pytest below 9.2 for pytest-benchmark - #818
Merged
Merged
Conversation
pytest 9.2 removed Node._nodeid, which pytest-benchmark 5.3.0 uses. See ionelmc/pytest-benchmark#321. Assisted-by: ClaudeCode:claude-opus-5-5
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #818 +/- ##
=======================================
Coverage 95.31% 95.31%
=======================================
Files 32 32
Lines 1410 1410
=======================================
Hits 1344 1344
Misses 66 66 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Oct 28, 2026
Member
Author
|
🤖 AI text below 🤖 Another option is the workaround from scikit-hep/mplhep#771. It does not cap pytest. A def pytest_collection_modifyitems(items):
for item in items:
if not hasattr(item, "_nodeid"):
item._nodeid = item.nodeidIf you prefer that, I can change this PR to use it. |
eduardo-rodrigues
added
CI
dependencies
eduardo-rodrigues
approved these changes
Oct 28, 2026
eduardo-rodrigues
left a comment
eduardo-rodrigues
left a comment
Member
There was a problem hiding this comment.
Hi @henryiii, thank you for spotting the issue and fixing it on the fly.
I'm fine with the cap and will then proceed with my major update tomorrow. Happy to see this merged. Many thanks.
ikrommyd
pushed a commit
to scikit-hep/numba-stats
that referenced
this pull request
Oct 29, 2026
🤖 _AI text below_ 🤖 pytest 9.2 removed `Node._nodeid`. pytest-benchmark 5.3.0 (latest) still uses it, so tests that use the `benchmark` fixture error at setup. This caps pytest below 9.2 until ionelmc/pytest-benchmark#321 is fixed in a release. Same as scikit-hep/particle#818 and scikit-hep/boost-histogram#1201. I checked locally that the benchmark tests fail with pytest 9.2.0 and pytest-benchmark 5.3.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Worrisome this has persisted for a bit without response, if it continues we might need to look for alternatives.
🤖 AI text below 🤖
pytest 9.2 removed
Node._nodeid. pytest-benchmark 5.3.0 (latest) still uses it, so the benchmark tests error (see CI on #817). This caps pytest below 9.2 in thedevandtestextras until ionelmc/pytest-benchmark#321 is fixed in a release.