Repository navigation
feat: drop pypy, fix memory bug, cap pytest - #1201
Merged
Merged
Conversation
pytest 9.2 removed Node._nodeid, which pytest-benchmark 5.3.0 still uses. Assisted-by: ClaudeCode:claude-opus-5-5
This was referenced Oct 28, 2026
Member
Author
|
🤖 AI text below 🤖 Another option is the workaround from scikit-hep/mplhep#771. It does not cap pytest. A def pytest_collection_modifyitems(items):
for item in items:
if not hasattr(item, "_nodeid"):
item._nodeid = item.nodeidIf you prefer that, I can change this PR to use it. |
ikrommyd
pushed a commit
to scikit-hep/numba-stats
that referenced
this pull request
Oct 29, 2026
🤖 _AI text below_ 🤖 pytest 9.2 removed `Node._nodeid`. pytest-benchmark 5.3.0 (latest) still uses it, so tests that use the `benchmark` fixture error at setup. This caps pytest below 9.2 until ionelmc/pytest-benchmark#321 is fixed in a release. Same as scikit-hep/particle#818 and scikit-hep/boost-histogram#1201. I checked locally that the benchmark tests fail with pytest 9.2.0 and pytest-benchmark 5.3.0.
&storage[0] on an empty storage (empty growth axes) indexes out of bounds; GCC 15 debug builds abort on it. Assisted-by: ClaudeCode:claude-opus-5-5
Without spaces the specifier is not quoted, and cmd.exe reads <9.2 as a redirect. Assisted-by: ClaudeCode:claude-opus-5-5
The runner image has /usr/bin/python3.14, which FindPython picked over 3.14t. PyPy 8 has no numpy wheels. Assisted-by: ClaudeCode:claude-opus-5-5
v4.3 quotes shell metacharacters on Windows (pypa/cibuildwheel#2978), so the pytest cap no longer needs spaces. It also adds PyPy 3.12 and GraalPy 25.3 wheels; skip their tests until numpy has wheels for them. Assisted-by: ClaudeCode:claude-opus-5-5
cibuildwheel 4.3 builds pp311 with PyPy 8 too, and numpy has no wheels for it. Assisted-by: ClaudeCode:claude-opus-5-5
PyPy 8 has no numpy wheels, so the PyPy wheels cannot be tested. Restore when numpy ships them. Assisted-by: ClaudeCode:claude-opus-5-5
henryiii
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spacing bug was fixed in cibuildwheel 4.3.0+.
🤖 AI text below 🤖
pytest 9.2 removed
Node._nodeid. pytest-benchmark 5.3.0 (latest) still uses it, so the wheel tests fail on all platforms (cibuildwheel does not use the lock file). This caps pytest below 9.2 in thetestgroup until ionelmc/pytest-benchmark#321 is fixed in a release. Same as scikit-hep/particle#818.