Repository navigation
Expose the request context on the RSpec controller helpers response - #316
Merged
Merged
Conversation
…pers response Matchers that judge a response need the context the action ran with, e.g. to call model fields that read graphql_context. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #316 +/- ##
=======================================
Coverage 98.17% 98.17%
=======================================
Files 68 68
Lines 1920 1922 +2
=======================================
+ Hits 1885 1887 +2
Misses 35 35 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the reason for this feature?
Currently, the RSpec controller helpers keep the request private, so a matcher judging
responsecan't see the context the action ran with.rspec_extra_matchers'be_successful_graphql_requestneeds it to call model fields that readgraphql_context, as GraphqlRails does at runtime.This PR adds
response.context, which returns the request's context (the hash-likeFakeContext, not aGraphQL::Query::Context).Reviewers should know:
FakeContextdelegates only[],[]=,to_h,key?andfetch. Decorators that callgraphql_context&.dig(...)will raise once the matcher passes this context. That is still open: addingdigtoFakeContexthere is the likely fix.