Repository navigation
Let the RSpec controller helpers test context be read with dig - #317
Merged
Merged
Conversation
FakeContext now delegates dig, as GraphQL::Query::Context does, so models that call graphql_context&.dig(...) work with the context that response.context exposes. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #317 +/- ##
=======================================
Coverage 98.17% 98.17%
=======================================
Files 68 68
Lines 1922 1922
=======================================
Hits 1887 1887
Misses 35 35 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the reason for this feature?
Currently, the RSpec controller helpers'
FakeContextdelegates only[],[]=,to_h,key?andfetch. Since #316 exposes it asresponse.context,rspec_extra_matchers'be_successful_graphql_requestpasses it to model fields. Fields that callgraphql_context&.dig(...)then raiseNoMethodError, thoughGraphQL::Query::Contextsupportsdigat runtime.This PR delegates
digfromFakeContextto the provided values and documents which methods the test context supports.Reviewers should know:
🤖 Generated with Claude Code