Rollup of 3 pull requests by jhpratt · Pull Request #158162 · rust-lang/rust

jhpratt · 2026-06-20T00:29:28Z

Successful merges:

Improve NumBufferTrait associated items #157976 (Improve NumBufferTrait associated items)
Suggest type next to visibility for const items #157382 (Suggest type next to visibility for const items)
Use the direct From in Clone for OnceLock<T> #158157 (Use the direct From in Clone for OnceLock<T>)

…ze depends on the integer instead of being the same for all integers

Again, the complexity of `set` is not necessary here.

@Amanieu

…ovement, r=Amanieu Improve `NumBufferTrait` associated items It allows for `NumBuffer::buf` size to depend on the integer instead of being the same for all integers. The idea was suggested by @Amanieu (thanks a lot!). r? @Amanieu

…vooeo Suggest `type` next to visibility for const items resolve: rust-lang#157368 Adjusts the `type const` suggestion to preserve visibility ordering, so `pub const` is suggested as `pub type const` instead of `type pub const`.

Use the direct `From` in `Clone for OnceLock<T>` This is a followup to rust-lang#158101 as again, the complexity of `set` is not necessary here, especially because we can now use that direct `From`. r? tgross35

jhpratt · 2026-06-20T00:29:42Z

@bors r+ rollup=never p=5

rust-bors · 2026-06-20T00:29:45Z

📌 Commit e8809e3 has been approved by jhpratt

It is now in the queue for this repository.

Rollup of 3 pull requests Successful merges: - #157976 (Improve `NumBufferTrait` associated items) - #157382 (Suggest `type` next to visibility for const items) - #158157 (Use the direct `From` in `Clone for OnceLock<T>`)

rust-bors · 2026-06-20T00:44:37Z

💔 Test for f3bf235 failed: CI. Failed job:

auto - x86_64-gnu-llvm-21-2 (web logs, enhanced plaintext logs)

jhpratt · 2026-06-20T00:46:14Z

@bors treeclosed=5

@bors retry

rust-bors · 2026-06-20T00:46:17Z

Tree closed for PRs with priority less than 5.

rust-log-analyzer · 2026-06-20T00:53:09Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

  RUST_BACKTRACE: 1
  TOOLSTATE_PUBLISH: 1
##[endgroup]
    Updating crates.io index
error: failed to get `cookie` as a dependency of package `cookie_store v0.21.1`
    ... which satisfies dependency `cookie_store = "^0.21.1"` of package `ureq v3.0.8`
    ... which satisfies dependency `ureq = "^3"` of package `citool v0.1.0 (/home/runner/work/rust/rust/src/ci/citool)`

Caused by:
  failed to load source for dependency `cookie`

Caused by:
  unable to update registry `crates-io`

Caused by:
  download of co/ok/cookie failed

Caused by:
  curl failed

Caused by:

jhpratt · 2026-06-20T02:21:12Z

@bors treeclosed-

rust-bors · 2026-06-20T02:21:14Z

Tree is now open for merging.

rust-bors · 2026-06-20T03:54:45Z

☀️ Test successful - CI
Approved by: jhpratt
Duration: 3h 7m 57s
Pushing 8c75e93 to main...

rust-timer · 2026-06-20T03:55:39Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#157382	Suggest `type` next to visibility for const items	`279b54833e22d63eb3e4aa3e6b230e267e64844d` (link)
#157976	Improve `NumBufferTrait` associated items	`94ec748948f697efeba4587f417fdab06c815841` (link)
#158157	Use the direct `From` in `Clone for OnceLock<T>`	`32f103161b10f6e919ef9f380d69e9d358b4c2b8` (link)

previous master: 32ea3615cc

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2026-06-20T03:57:57Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 32ea361 (parent) -> 8c75e93 (this PR)

Test differences

Show 17 test diffs

Stage 1

[ui] tests/ui/const-generics/mgca/suggest-pub-type_const.rs: [missing] -> pass (J0)
[ui (polonius)] tests/ui/const-generics/mgca/suggest-pub-type_const.rs: [missing] -> pass (J2)

Stage 2

[ui] tests/ui/const-generics/mgca/suggest-pub-type_const.rs: [missing] -> pass (J1)

Additionally, 14 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 8c75e93c5c7671c29f3e8c096b7acf56822ed23a --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-gnu-next-trait-solver-polonius: 42m 22s -> 1h 1m (+45.1%)
dist-x86_64-msvc: 1h 37m -> 2h 10m (+34.3%)
optional-x86_64-gnu-parallel-frontend: 2h 19m -> 2h 57m (+27.6%)
dist-powerpc64le-linux-gnu: 1h 16m -> 1h 35m (+25.5%)
dist-ohos-aarch64: 1h 1m -> 1h 15m (+23.4%)
dist-x86_64-llvm-mingw: 1h 31m -> 1h 52m (+22.2%)
dist-x86_64-msvc-alt: 2h 36m -> 2h 5m (-19.6%)
dist-armv7-linux: 1h 29m -> 1h 12m (-18.8%)
dist-powerpc64-linux-musl: 1h 32m -> 1h 15m (-18.6%)
aarch64-apple: 3h 8m -> 2h 38m (-15.5%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-06-20T04:35:31Z

Finished benchmarking commit (8c75e93): comparison URL.

Overall result: ❌ regressions - please read:

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.3%, 0.8%]	6
Regressions ❌ (secondary)	0.6%	[0.1%, 1.1%]	21
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.4%	[0.3%, 0.8%]	6

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 489.308s -> 480.613s (-1.78%)
Artifact size: 390.69 MiB -> 390.68 MiB (-0.00%)

jhpratt · 2026-06-20T07:32:14Z

Caused by #157976

@rustbot label perf-regression-triaged

reddevilmidzy and others added 6 commits June 9, 2026 02:22

Suggest type next to visibility for const items

5ea3958

Improve NumBufferTrait associated items so that NumBuffer::buf si…

c558f6b

…ze depends on the integer instead of being the same for all integers

Use the direct From in Clone for OnceLock<T>

cced652

Again, the complexity of `set` is not necessary here.

Rollup merge of rust-lang#158157 - cuviper:once_lock-clone, r=tgross35

e8809e3

Use the direct `From` in `Clone for OnceLock<T>` This is a followup to rust-lang#158101 as again, the complexity of `set` is not necessary here, especially because we can now use that direct `From`. r? tgross35

rust-bors Bot added the rollup A PR which is a rollup label Jun 20, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 20, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 20, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2026

rust-bors Bot mentioned this pull request Jun 20, 2026

Improve NumBufferTrait associated items #157976

Merged

This comment has been minimized.

Sign in to view

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 20, 2026

rust-bors Bot merged commit 8c75e93 into rust-lang:main Jun 20, 2026
14 checks passed

rustbot added this to the 1.98.0 milestone Jun 20, 2026

jhpratt deleted the rollup-sVgABWZ branch June 20, 2026 03:55

rustbot added the perf-regression Performance regression. label Jun 20, 2026

jhpratt mentioned this pull request Jun 20, 2026

Use the direct From in Clone for OnceLock<T> #158157

Merged

rustbot added the perf-regression-triaged The performance regression has been triaged. label Jun 20, 2026

Uh oh!

Conversation

jhpratt commented Jun 20, 2026

Uh oh!

jhpratt commented Jun 20, 2026

Uh oh!

rust-bors Bot commented Jun 20, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jun 20, 2026

Uh oh!

jhpratt commented Jun 20, 2026

Uh oh!

rust-bors Bot commented Jun 20, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Jun 20, 2026

Uh oh!

jhpratt commented Jun 20, 2026

Uh oh!

rust-bors Bot commented Jun 20, 2026

Uh oh!

rust-bors Bot commented Jun 20, 2026

Uh oh!

Uh oh!

rust-timer commented Jun 20, 2026

Uh oh!

github-actions Bot commented Jun 20, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Jun 20, 2026

Overall result: ❌ regressions - please read:

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

jhpratt commented Jun 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants