Improve NumBufferTrait associated items#157976
Conversation
…ze depends on the integer instead of being the same for all integers
|
Some changes occurred in integer formatting cc @tgross35 |
|
@bors r+ |
|
⌛ Testing commit c558f6b with merge 22398ff... Workflow: https://github.com/rust-lang/rust/actions/runs/27855057977 |
|
yielding to rollup @bors yield |
|
Auto build was cancelled. Cancelled workflows: The next pull request likely to be tested is #158162. |
|
@rust-timer build 94ec748 |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (94ec748): comparison URL. Overall result: ❌ regressions - please read:Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. Next, please: If you can, justify the regressions found in this try perf run in writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 2.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 3.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 489.308s -> 480.969s (-1.70%) |
|
I'm surprised: is any of these using |
It allows for
NumBuffer::bufsize to depend on the integer instead of being the same for all integers.The idea was suggested by @Amanieu (thanks a lot!).
r? @Amanieu