Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/danger.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@ on:

jobs:
danger:
uses: numbata/danger-pr-comment/.github/workflows/danger-run.yml@v0.1.0
uses: numbata/danger-pr-comment/.github/workflows/danger-run.yml@v0.2.0
secrets: inherit
with:
ruby-version: '3.4'
gemfile: gemfiles/danger.gemfile
bundler-cache: true
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#### Features

* [#3052](https://github.com/ruby-grape/grape/pull/3052): Add `Grape::ErrorFormatter::ProblemJson` to answer errors as RFC 9457 problem details - [@ericproulx](https://github.com/ericproulx).
* [#3062](https://github.com/ruby-grape/grape/pull/3062): Use the reusable Danger workflow with a separate Gemfile - [@dblock](https://github.com/dblock).
* Your contribution here.

#### Fixes
Expand Down
5 changes: 0 additions & 5 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,6 @@ group :development do
end

group :test do
gem 'danger', require: false
gem 'danger-changelog', require: false
gem 'danger-pr-comment', require: false
# danger 9.6.1 fails to load with git 6: https://github.com/danger/danger/issues/1560
gem 'git', '< 6', require: false
gem 'rack-contrib', require: false
gem 'rack-test', '~> 2.1'
# ActiveSupport::XmlMini, Grape's XML backend without multi_xml, parses with
Expand Down
14 changes: 14 additions & 0 deletions gemfiles/danger.gemfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# frozen_string_literal: true

# Danger's own bundle, used only by .github/workflows/danger.yml, so that its
# gems stay out of the bundle every other Gemfile evaluates. To run it locally:
#
# BUNDLE_GEMFILE=gemfiles/danger.gemfile bundle exec danger local

source 'https://rubygems.org'

gem 'danger'
gem 'danger-changelog'
gem 'danger-pr-comment'
# danger 9.6.1 fails to load with git 6: https://github.com/danger/danger/issues/1560
gem 'git', '< 6'
Loading