Repository navigation
Use reusable Danger workflow with a separate Gemfile - #3062
Merged
Merged
Conversation
dblock
force-pushed
the
dblock/danger-gemfile-input
branch
from
November 7, 2026 13:26
40d3394 to
66adb6f
Compare
Danger ReportNo issues found. |
Danger ran from the main Gemfile's :test group, which every gemfile in gemfiles/ evaluates. So each test job resolved and installed Danger's gems as well: 28 of the bundle's 90, Faraday, Octokit and kramdown among them. The `git < 6` pin (ruby-grape#3045) went to every bundle too. gemfiles/danger.gemfile now holds danger, danger-changelog, danger-pr-comment and the git pin, and nothing else, not even the gemspec. The main Gemfile drops them. numbata/danger-pr-comment's danger-run.yml can't pick a Gemfile, and a caller's env doesn't reach a reusable workflow. danger.yml therefore runs that workflow's steps itself, with BUNDLE_GEMFILE set on the job. The report artifact keeps the same names, so danger-comment.yml still posts the PR comment unchanged. The Dangerfile is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dblock
force-pushed
the
dblock/danger-gemfile-input
branch
from
November 7, 2026 13:36
66adb6f to
e95abc9
Compare
ericproulx
approved these changes
Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3057. It keeps Danger in
gemfiles/danger.gemfilebut uses the newgemfileinput innumbata/danger-pr-commentrather than copying the reusable workflow steps into Grape.The workflow calls
numbata/danger-pr-comment/.github/workflows/danger-run.yml@mainwithgemfile: gemfiles/danger.gemfile. The Danger Comment workflow and its report artifact remain unchanged.Validation
bundle exec rake(379 files inspected, 3,184 examples, 0 failures)gemfileinput was merged to danger-pr-commentmainin Allow error! to support objects #13.