Skip to content

ci: build tiktoken musllinux wheels for riscv64 - #2629

Merged
luhenry merged 4 commits into
mainfrom
fix/tiktoken-musllinux-riscv64
Oct 2, 2026
Merged

luhenry merged 4 commits into
mainfrom
fix/tiktoken-musllinux-riscv64

Conversation

@gounthar

@gounthar gounthar commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

Rust 1.99.0 (2026-10-01) ships riscv64gc-unknown-linux-musl on stable, so sh.rustup.rs now installs inside the musllinux container and the skip can go.

Test run on 0.14.0: https://github.com/riseproject-dev/python-wheels/actions/runs/36978067634
All four Pythons build a musllinux wheel and pass 33/33 tests. The first py314 attempt hit a rustc SIGSEGV compiling regex-automata; the re-run on another runner was clean.

Older versions only get musl wheels if dispatched by hand.

The musllinux skip was added because rustup.rs had no installer for
riscv64gc-unknown-linux-musl, and tiktoken's own cibuildwheel config
installs Rust in before-all through sh.rustup.rs. That reason no longer
holds: rustup 1.29.1 added the target, and Rust 1.99.0 (2026-10-01)
publishes it on the stable channel. Checked on 2026-10-02:
rustup-init for riscv64gc-unknown-linux-musl returns 200, and
channel-rust-stable.toml lists rustc 1.99.0 for that target.

Artifact names keep the manylinux_riscv64 suffix so the publish job's
artifact-pattern still matches; the musllinux wheels land in the same
artifact. Not yet run in CI.

Signed-off-by: Bruno Verachten <gounthar@gmail.com>
@luhenry

luhenry commented Oct 2, 2026

Copy link
Copy Markdown
Member

Can you update the docs/packages/tiktoken.yaml file to leave only the - version: ... lines, removing the tag: and files: entries for each version. This will re-trigger the build for each version.

@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-10-02 16:26 UTC

@gounthar
gounthar marked this pull request as draft October 2, 2026 13:17
@gounthar
gounthar marked this pull request as ready for review October 2, 2026 16:20
@luhenry
luhenry merged commit 7881ca8 into main Oct 2, 2026
12 checks passed
@luhenry
luhenry deleted the fix/tiktoken-musllinux-riscv64 branch October 2, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants