Repository navigation
feat: adopt native Liquid Glass - #32
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NSGlassEffectContainerViewwhile retaining weak-linkedNSVisualEffectViewfallbacks for macOS 12–25Why
Bro Computer forced Dark Aqua and relied on legacy HUD visual-effect views and custom colors. That prevented the shell from participating in macOS 26 native Liquid Glass behavior and made appearance changes fragile. The native tab-pill controls also need to live in each glass view’s
contentView; sibling controls can be composited beneath the refractive material and become unreadable.This implements #31 with native AppKit ownership, neutral Regular glass, one native tab container, appearance-aware fallbacks, and explicit compatibility gates.
User impact
On macOS 26, the window shell, chrome, tab pills, command palette, downloads panel, hover card, find panel, and zoom HUD now use native Liquid Glass. Users can select System, Light, or Dark appearance from the app menu, and the choice persists. Older supported macOS releases retain a functional adaptive visual-effect fallback.
Validation
cmake -S . -B build -G Ninjacmake --build buildctest --test-dir build --output-on-failure— 2/2 passedswiftc -typecheck -module-cache-path /tmp/bro-swift-module-cache tests/ax_smoke.swiftWEBGL_OKacross two tabs and screenshot modeNSGlassEffectViewandNSGlassEffectContainerViewimportsgit diff --checkCloses #31.