Skip to content

Fix browser-process crash on SPA soft navigations #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ragojose merged 1 commit into from
Aug 11, 2026
Merged

Fix browser-process crash on SPA soft navigations #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/bro_app.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

#include "bro_app.h"

#include <string>

#include "include/cef_command_line.h"
#include "include/wrapper/cef_helpers.h"
#include "bro_handler.h"
Expand All @@ -27,6 +29,24 @@ void BroApp::OnBeforeCommandLineProcessing(
command_line->AppendSwitch("enable-gpu");
command_line->AppendSwitchWithValue("use-angle", "metal");
command_line->AppendSwitch("ignore-gpu-blocklist");

// Chrome's Reading Mode ships in CEF without the profile plumbing it
// expects: its ReadAnythingSoftNavigationObserver dereferences a null
// coordinator the moment any page performs a soft navigation (History API /
// same-document), taking the whole browser process down. Symbolicated from
// a field crash on wakawaka.world, 2026-08-11 (build 85). Disabling the
// feature removes the observer; merge with any existing list rather than
// clobbering the features CEF disables on its own.
const char kDisableFeatures[] = "disable-features";
std::string disabled =
command_line->HasSwitch(kDisableFeatures)
? command_line->GetSwitchValue(kDisableFeatures).ToString()
: std::string();
if (!disabled.empty()) {
disabled += ",";
}
disabled += "ReadAnything";
command_line->AppendSwitchWithValue(kDisableFeatures, disabled);
}

void BroApp::OnContextInitialized() {
Expand Down
Loading