Repository navigation
Fix browser-process crash on SPA soft navigations - #28
Merged
Merged
Conversation
Any site performing a soft navigation (History API / same-document, the standard SPA pattern) could take down the whole browser process: Chrome's ReadAnythingSoftNavigationObserver ships in CEF without the profile plumbing it expects and dereferences null on the first OnSoftNavigation callback. Root-caused by symbolicating a field crash (build 85, wakawaka.world internal page -> home) against CEF's published dSYMs. Disabling the ReadAnything feature removes the observer entirely; the switch merges with CEF's own disable-features list rather than clobbering it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Navigating within an SPA-style site could crash the entire browser (reported: wakawaka.world, internal page → homepage, build 85). Symbolicating the crash against CEF's published dSYMs pinned it to Chromium, not our code:
ReadAnythingSoftNavigationObserver::OnSoftNavigation()— Chrome's Reading Mode feature, shipped inside CEF without the profile infrastructure it expects — dereferences null on the first soft-navigation callback any page emits. Disabling theReadAnythingfeature removes the observer.Summary
bro_app.cc: appendReadAnythingtodisable-features, merging with the list CEF already sets (verified on a live process:--disable-features=AutofillActorMode,GlicActorUi,KillOnInvalidNavigationHeaders,LensOverlay,ReadAnything)Test plan