Skip to content

Fix invisible idle address text in the glass chrome #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arzafran wants to merge 1 commit into from
Closed

Fix invisible idle address text in the glass chrome #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/bro_toolbar.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,11 @@ - (instancetype)initWithFrame:(NSRect)frame {
_addressField.bordered = NO;
_addressField.drawsBackground = NO;
_addressField.focusRingType = NSFocusRingTypeNone;
_addressField.textColor = [NSColor labelColor];
// Explicit white, not labelColor: the chrome row is a vibrancy surface,
// and semantic colors composite through the glass material where they
// can lose contrast against the dark pill. Every other chrome color in
// this file is already explicit for the same reason.
_addressField.textColor = [NSColor whiteColor];
_addressField.delegate = self;
_addressField.cell.scrollable = YES;
_addressField.cell.usesSingleLineMode = YES;
Expand Down Expand Up @@ -507,7 +511,8 @@ - (void)controlTextDidEndEditing:(NSNotification*)notification {
if ([_addressField.superview isKindOfClass:[BroTabView class]]) {
((BroTabView*)_addressField.superview).editingAddress = NO;
}
_addressField.textColor = [NSColor labelColor];
// Same explicit white as the init path — see the comment there.
_addressField.textColor = [NSColor whiteColor];
[self displayCompactURL];
}
}
Expand Down
Loading