Repository navigation
Conversation
The idle-state text color was labelColor while the editing state hard-set white. The chrome row became a vibrancy surface recently, and semantic colors composite through the glass where they can lose all contrast against the dark pill — the URL disappeared until you clicked in. Both states now use the same explicit white every other chrome color in this file already uses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
The URL in the address pill was invisible until you clicked into the field (screenshot in the report from arzafran). The idle state used
labelColorwhile the editing state hard-set white — and the chrome row is now a vibrancy surface, where semantic colors composite through the glass and can lose all contrast against the dark pill. Both states now use the same explicit white as every other chrome color in the file.Two lines. A proper fix — dynamic colors + light/dark/system theme support — is planned as its own feature; this stops the bleeding in the current dark-only design.
Test plan