Repository navigation
Conversation
When the stored minimum gear ratio is zero and the absolute differential rotational speed is below 0.5, initialize lastRatio using the sign of maxGearRatio and the absolute motor rotational speed. The previous expression derived the initial ratio directly from motor rotational speed. This could produce a positive initial ratio while a negative ratio was requested for reverse. Because lastRatio is subsequently blended with maxGearRatio, an incorrect initial sign can alter the start transition. I previously experienced an abrupt start in reverse with manual transmissions, using both keyboard and controller input. After applying this correction, I confirmed that the reported reverse-start issue was resolved. This is a gameplay observation from my installation, not a complete regression test across all vehicles and transmission configurations.
Owner
|
accepted. Visible in next release on github. Thanks again |
Author
|
Happy to help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the stored minimum gear ratio is zero and the absolute differential rotational speed is below 0.5, initialize lastRatio using the sign of maxGearRatio and the absolute motor rotational speed.
The previous expression derived the initial ratio directly from motor rotational speed. This could produce a positive initial ratio while a negative ratio was requested for reverse.
Because lastRatio is subsequently blended with maxGearRatio, an incorrect initial sign can alter the start transition.
I previously experienced an abrupt start in reverse with manual transmissions, using both keyboard and controller input. After applying this correction, I confirmed that the reported reverse-start issue was resolved.
This is a gameplay observation from my installation, not a complete regression test across all vehicles and transmission configurations.