Repository navigation
Conversation
It might be intentional so if it is the case please ignore. I am just trying to support but do not have the full picture of the code. VehicleMotor.mrUpdateStartGearValues reads self.mrTransmissionManagedByMR but self refers to the VehicleMotor instance. The flag is maintained on the vehicle by WheelsUtil.mrUpdateWheelsPhysics. Read it through self.vehicle.mrTransmissionManagedByMR instead. This restores the selection between MR available-power calculation and the original updateStartGearValues implementation. When the vehicle flag is false or unset, the original implementation remains in use.
Owner
|
accepted. Again, this is really helpful, many thanks. Fixed in the next release. (this bug was introduced while trying to separate autodrive from MR) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It might be intentional so if it is the case please ignore. I am just trying to support but do not have the full picture of the code.
VehicleMotor.mrUpdateStartGearValues reads self.mrTransmissionManagedByMR but self refers to the VehicleMotor instance.
The flag is maintained on the vehicle by WheelsUtil.mrUpdateWheelsPhysics. Read it through self.vehicle.mrTransmissionManagedByMR instead.
This restores the selection between MR available-power calculation and the original updateStartGearValues implementation. When the vehicle flag is false or unset, the original implementation remains in use.