Repository navigation
Conversation
Make the server authoritative for MR moisture values while retaining the existing temperature- and sunlight-based formulas. Send updated moisture values to clients when they change, and send the current state to newly joining clients. Integrate daytime drying using elapsed time and the effective time scale. Persist accumulated dampness through the existing weather XML save/load hooks using the MRdampness attribute. Replace the previous RealisticMain weather update loop with a Weather.update hook and clear pending state when leaving the map. Use the neutral identifiers MRweather, MRwetnessEvent and MRwetness. No forecasts, rainfall, cloud settings or traction coefficients are changed.
Make the server authoritative for MR moisture values while retaining the existing temperature- and sunlight-based formulas. Send updated moisture values to clients when they change, and send the current state to newly joining clients. Integrate daytime drying using elapsed time and the effective time scale. Persist accumulated dampness through the existing weather XML save/load hooks using the MRdampness attribute. Replace the previous RealisticMain weather update loop with a Weather.update hook and clear pending state when leaving the map. Use the neutral identifiers MRweather, MRwetnessEvent and MRwetness. No forecasts, rainfall, cloud settings or traction coefficients are changed.
Owner
|
ok. I don't think the "mr wetness" is useful for client side. but I accepted the solution to keep the value in the savegame. Will be present in next release (with slight changes) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CONTEXT
The existing implementation maintains MR moisture state separately on each game instance. A client joining an ongoing session can start with a different accumulated dampness history from the server.
Accumulated MR dampness is also not persisted by this implementation, so reloading a save can reset the drying history.
CHANGES
SCOPE
The temperature and sunlight based moisture formulas are retained.
This synchronizes MR moisture values, not the complete native weather system. Original game coefficients and game time-scale settings are unchanged.
Only accumulated dampness is persistent.
Minimum and effective wetness are recalculated.
FILES CHANGED
NAMING
The implementation uses:
TESTED
Existing official saves without MRdampness remain supported, the accumulated dampness will initially start at zero.
Tested in singleplayer and on dedicated server.