Preserve source knurl maximum diameter in manufacturing output - #2179
Merged
Merged
Conversation
Render the full source-owned knurl requirement in schedule rows while keeping the compact suffix for direct diameter callouts. Compare placed rows against that complete text in lint. Preserve source pitch, chamfer, and diameter precision.
A 10.05 mm source knurl previously produced a schedule row with ø10.05 and a referring diameter leader with ø10.1. Compile source knurl diameters with the source magnitude precision as a floor, including when a caller requests one decimal place. Keep the ordinary formatting path for other dimensions. A public drawing guard covers automatic and one-decimal requests; restoring the old formatting rule makes both named cases fail. The compiled source tier selects that guard. Focused tests and scripts/pr-check --static pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2175.
Change
Evidence
build_drawing(path, pmi="annotate")printsø10 MAX AFTER KNURLin MFG 3 andø10 SEE MFG 3on the linked leader, without non-info manufacturing lint.ø10.05in both places. A named public-path guard mutates the leader toø10.04, deletes its diameter, and removes the row maximum while mutating the row formatter; each mutation must producemanufacturing_reference_unresolved.scripts/pr-check --staticpassed on the final head.bfb21a3cagainst main30ee9c11with no remaining actionable issue.Architecture
The source maximum enters the ADR 1 model waist, flows through the ADR 4 compiled plan, and is checked on finished annotations by ADR 5 lint. The ADR 3 STEP evidence and ADR 2 placement policy remain at their existing boundaries. No ADR text or invariant changes.
Required CI on the exact final PR head is the merge gate.