Render source-scoped AP242 edge and face finish PMI - #2180
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2176.
Change
edge conditionrequirement to a GENERAL NOTES entry with exact source text and identity.surface finishrequirement to a scoped finish leader only when its STEP reference resolves to one exact supported cylindrical face. Preserve the corrected producer's document-defaultsurface texturepath.Evidence
Break sharp edges 0.2 max, and face-specific Ra 0.8 on one cylinder. The drawing presents all three in their proper scopes.0.2→9.9glyph mutation is detected even when table metadata and PDF text still claim the source text. Separate tests cover wrong finish face, displaced leader tip, numeric ink, missing/false source identity, Part 21 mismatch, and extraction-only IDs.scripts/pr-check --staticpassed. Deliberate source, ink, tip, and CI-route mutations fail their named guards.detected-geometry. The new emitted-script assertion failed before the fix. Source-linked finishes now emitpmi, authored finishes retainauthored; all 33 manufacturing-finish tests and static checks passed.9d66ccd3, then reviewed the focused provenance correction at94d64543; no finding remains. Required exact-head CI remains the merge gate.Architecture
ADR 1 retains one IR/lowering path and the ranked DAG. ADR 2 keeps placement in the shared corridor. ADR 3 uses exact STEP source-face evidence. ADR 4 preserves compiled meaning through editable replay. ADR 5 independently checks the settled mark and refuses unsupported claims. No ADR invariant changes.