Skip to content

Render source-scoped AP242 edge and face finish PMI - #2180

Merged
pzfreo merged 12 commits into
mainfrom
fix/pmi-edge-finish-2176
Oct 4, 2026
Merged

pzfreo merged 12 commits into
mainfrom
fix/pmi-edge-finish-2176

Conversation

@pzfreo

@pzfreo pzfreo commented Oct 4, 2026 •

Copy link
Copy Markdown
Owner

Fixes #2176.

Change

  • Lower the producer's part-level edge condition requirement to a GENERAL NOTES entry with exact source text and identity.
  • Lower a face-specific surface finish requirement to a scoped finish leader only when its STEP reference resolves to one exact supported cylindrical face. Preserve the corrected producer's document-default surface texture path.
  • Carry source identity through the model, drawing, editable Sheet script, replay, and independent lint. Refuse unsupported or unverifiable claims.
  • Independently check the source edge note's kind, Part 21 identity, text metadata, and settled vector glyphs; check both the finish's declared site and placed tip against source face evidence. Classify source-text errors as fidelity faults and classify the existing title-default codes that the quality audit exposed.

Evidence

  • The public AP242 fixture carries document-default Ra 3.2, Break sharp edges 0.2 max, and face-specific Ra 0.8 on one cylinder. The drawing presents all three in their proper scopes.
  • Public Sheet replay tests reject an edge note with a wrong Part 21 ID, a real source ID of the wrong kind, an unknown source ID, and an edge source disguised as a datum note. A genuine source-linked datum note remains valid. A source-linked note without a STEP census reports an unverified claim.
  • A same-width 0.2→9.9 glyph mutation is detected even when table metadata and PDF text still claim the source text. Separate tests cover wrong finish face, displaced leader tip, numeric ink, missing/false source identity, Part 21 mismatch, and extraction-only IDs.
  • A fresh reviewer also found that a printed finish or note could claim a Part 21 ID without a source ID. Four public Sheet cases prove that defect after asserting the mark is printed, and the new guard reports the incomplete source claim both with and without a STEP census. The four tests failed on the pre-fix code and pass with the guard; wholly authored notes remain valid.
  • Another review found a valid STEP edge note with two spaces at a wrap boundary that was falsely flagged. Lint now compares source-derived printed rows, source words independently, and settled glyphs. The public STEP regression failed before the fix and passes now. A deliberate mutation that drops words in both the renderer and lint formatter makes the independent word guard fail as intended.
  • On the rebased branch atop merged Preserve source knurl maximum diameter in manufacturing output #2179, 225 adjacent PMI, manufacturing, and tier tests passed (one deselected). After the source-shape and Part 21 corrections, 68 adjacent PMI tests, 32 structural/import tests, seven source-shape tests, and scripts/pr-check --static passed. Deliberate source, ink, tip, and CI-route mutations fail their named guards.
  • Linux CI found four STEP title-default diagnostics without a bounded remediation domain. The focused reporting correction passed 22 adjacent tests, the exact-domain guard, and static checks; removing one mapping deliberately fails that guard.
  • A later Linux shard showed the read-only STEP inspection now constructs the exact PMI topology resolver. The pinned engine-module test failed before its inventory was updated; all 49 inspection tests and the separate no-drawing-stage guard passed after the correction.
  • Final review caught an imported face finish whose editable script labelled it detected-geometry. The new emitted-script assertion failed before the fix. Source-linked finishes now emit pmi, authored finishes retain authored; all 33 manufacturing-finish tests and static checks passed.
  • Independent Google-style reviews found concrete provenance and lint defects; each was fixed. The reviewer examined the cumulative production diff through 9d66ccd3, then reviewed the focused provenance correction at 94d64543; no finding remains. Required exact-head CI remains the merge gate.

Architecture

ADR 1 retains one IR/lowering path and the ranked DAG. ADR 2 keeps placement in the shared corridor. ADR 3 uses exact STEP source-face evidence. ADR 4 preserves compiled meaning through editable replay. ADR 5 independently checks the settled mark and refuses unsupported claims. No ADR invariant changes.

@pzfreo
pzfreo merged commit 97248b0 into main Oct 4, 2026
19 checks passed
@pzfreo
pzfreo deleted the fix/pmi-edge-finish-2176 branch October 4, 2026 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rc5: part-level surface texture and edge-condition requirements vanish from the sheet (pmi_not_lowered)

1 participant