Reconcile AP242 diameter PMI with recognized feature measurements - #2174
Merged
Merged
Conversation
Keep the smaller CTC01 A3 candidate when it retains an authored GD&T frame that the A2 fallback drops. Only informational inferred losses may trade in this incomplete-case comparison; all losses remain in the decision record.
Use the automatic callout batching contract for the public edit verb. If a pattern needs several distinct size labels, fail before placing one label that would claim the wrong member tolerance.
Map the new pattern-member and AP242 diameter contracts to the source modules they defend. A source-only edit now selects these tests in the PR tier; test_tier_manifest checks both mappings. This follows the existing test selection contract and does not change drawing behavior.
A public pattern member cannot attribute its canonical bore diameter to a different source nominal. Validate NominalRequirement against the member diameter at the IR constructor, so direct Sheet declarations and generated-script replay use the same truth boundary. The new invalid-member test fails when agrees_with is deliberately bypassed; 163 affected tests and the static gate pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2172.
Change
Drawing.callout(pattern)in immediate and deferred modes when it would discard member-specific requirements.Evidence
nist_ctc_01_asme1_ap242.stpthroughbuild_drawing(path, pmi="annotate"): four Ø35 source requirements remain with their physical members; the generic 4× Ø35 label no longer repeats those sizes. The 2×2 pattern, THRU state, and pitches remain.1×.Review and architecture
Fresh independent review of the exact local diff through
44ce49adchecked all five ADRs and the CI corrections. It found no remaining concrete issue. The change stays within ADR 1's single model waist and DAG, ADR 2's collect-then-solve placement and honest infeasibility, ADR 3's recognition boundary, ADR 4's compiled-plan and provenance rule, and ADR 5's explicit refusal for ambiguous matches. No ADR invariant changes. Required CI on44ce49adis the merge gate.