Render one pitch gap without 1× prefix - #2173
Merged
Merged
Conversation
pzfreo
added a commit
that referenced
this pull request
Oct 3, 2026
pzfreo
added a commit
that referenced
this pull request
Oct 4, 2026
pzfreo
added a commit
that referenced
this pull request
Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A two-member pattern has one pitch gap. Render its approved pitch as
650, not1× 650. Multi-gap spans keep their multiplier (3× 25). The shared renderer covers hole, slot and pocket patterns; the independent pocket-pattern drawing evaluator now expects the same honest presentation while checking the confirmed measurement identity.Evidence
90,320,350, and650. A generated preview PDF was rendered and inspected.1×formatter deliberately failedtest_grid_pattern_renders_both_pitch_dims; the fix was restored byte-for-byte afterward.scripts/pr-check --staticpassed on the final change.Architecture
The approved pitch value and measurement identity still come from the ADR 1/4 compiled plan. Only the render text for a single gap changes. ADR 2 placement uses the same endpoints and shorter measured label. ADR 3 recognition is unchanged. ADR 5's independent drawing evaluator still checks the visible label against the confirmed claim. No ADR boundary changes.
The separate CTC01 repeated nominal diameter and distinct member-specific PMI presentation is tracked in #2172; this PR does not suppress either claim.
Follow-up at 785968c
The stacked #2174 full matrix found two additional consumers of the intentional one-gap text change. The grid-plate exact golden now records
20and its actual label bounds. The independent hole-pattern drawing evaluator now accepts a bare value for one interval and still requires the correct explicit multiplier for longer spans. Its mutation test proves that changing the real one-gap20to9× 20loses drawing credit; a wrong nominal also loses credit.The evaluator and golden updates passed 15 focused hole-pattern tests, all 23 refactor-golden cases, the exact grid-plate golden, ruff, mypy, and the source-complexity guard locally. A fresh independent review checked the final parent diff and its merge into #2174, found no concrete defect, and verified ADR 1–5 fit. The current exact-head CI is the merge gate.