gh-140025: Fix `queue.SimpleQueue.__sizeof__()` by Aniketsy · Pull Request #143137 · python/cpython

Aniketsy · 2025-12-24T12:05:37Z

Update SimpleQueue.sizeof() to include the memory used by its internal buffer.
add a unit test.

Please let me know if my approach or fix needs any improvements . I’m open to feedback and happy to make changes based on suggestions.
Thankyou !

Issue: queue.SimpleQueue.__sizeof__() ignores the underlying data structure #140025

colesbury

A few comments below. Please also add a blurb

colesbury · 2025-12-24T13:20:03Z

+static PyObject *
+simplequeue_sizeof(PyObject *op, PyObject *Py_UNUSED(ignored))
+{


This needs a critical section (a lock for the queue). The simplest way is to use "Argument Clinic" like the other functions.

Something like:

/*[clinic input] @critical_section _queue.SimpleQueue.__sizeof__ -> Py_ssize_t Returns size in memory, in bytes. [clinic start generated code]*/ static Py_ssize_t simplequeue_sizeof_impl(simplequeueobject *self) /*[clinic end generated code: output=3303f008eaa6a0a5 input=9b51620c76fc4507]*/

Then run make clinic to regenerate the bindings.

colesbury · 2025-12-24T13:20:47Z

    _QUEUE_SIMPLEQUEUE_PUT_METHODDEF
    _QUEUE_SIMPLEQUEUE_PUT_NOWAIT_METHODDEF
    _QUEUE_SIMPLEQUEUE_QSIZE_METHODDEF
+    {"__sizeof__", (PyCFunction)simplequeue_sizeof, METH_NOARGS, NULL},


You'll also need to change this to use the Argument Clinic methoddef (like above).

colesbury · 2025-12-24T13:22:01Z


+    def test_simplequeue_sizeof_reflects_buffer_growth(self):
+        q = self.type2test()
+        before = q.__sizeof__()


A few changes:

Don't use ctypes (no support for that in wasi)

Use support.calcobjsize

Use sys.getsizeof() instead of calling __sizeof__ directly

Aniketsy · 2025-12-24T14:57:48Z

@colesbury thanks for the feedback. i've applied changes as per suggestions, please let me know if this needs further improvement.

picnixz · 2025-12-25T18:55:23Z

thanks for the feedback. i've applied changes as per suggestions, please let me know if this needs further improvement.

Please make it so that the CI is green before requesting a new review.

Aniketsy · 2026-01-02T10:44:59Z

@picnixz ci is now green. @colesbury could you please review now if you get a chance. Thanks!

colesbury

Thanks a few comments below

colesbury · 2026-01-02T21:27:21Z

 from test.support import gc_collect, bigmemtest
 from test.support import import_helper
 from test.support import threading_helper
+import sys


Move import sys up between import random and import threading

sure, I missed that. I thought running pre-commit run would take care of it.

picnixz · 2026-01-02T22:08:51Z

+[clinic start generated code]*/
+
+static Py_ssize_t
+_queue_SimpleQueue___sizeof___impl(simplequeueobject *self)


Can you put the definition of this method after the definition of qsize please?

Sure, I’ll update this.

Co-authored-by: Sam Gross <colesbury@gmail.com>

…OX58_.rst Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

…OX58_.rst Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

bedevere-bot · 2026-01-08T13:05:54Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.x (tier-1) has failed when building commit f3e069a.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/345/builds/13136) and take a look at the build logs.
Check if the failure is related to this commit (f3e069a) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/345/builds/13136

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 946, in gc_collect
    gc.collect()
    ~~~~~~~~~~^^
ResourceWarning: unclosed file <_io.FileIO name=13 mode='wb' closefd=True>


Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 946, in gc_collect
    gc.collect()
    ~~~~~~~~~~^^
ResourceWarning: unclosed file <_io.FileIO name=11 mode='wb' closefd=True>

…ct size (python#143137)

implement __sizeof__ for SimpleQueue to account for ring-buffer storage

4d03baf

bedevere-app Bot added the awaiting review label Dec 24, 2025

bedevere-app Bot mentioned this pull request Dec 24, 2025

queue.SimpleQueue.__sizeof__() ignores the underlying data structure #140025

Open

colesbury reviewed Dec 24, 2025

View reviewed changes

Aniketsy added 2 commits December 24, 2025 20:04

implement __sizeof__ for SimpleQueue to account for ring-buffer storage

b2b05ea

implement __sizeof__ for SimpleQueue to account for ring-buffer storage

205fd00

picnixz changed the title ~~gh-140025: Fix Fix queue.SimpleQueue.__sizeof__()~~ gh-140025: Fix queue.SimpleQueue.__sizeof__() Dec 25, 2025

picnixz mentioned this pull request Dec 30, 2025

gh-140025: Fix queue.SimpleQueue.__sizeof__() to account for buffer #143277

Closed

implement __sizeof__ for SimpleQueue to account for ring-buffer storage

21014aa

Aniketsy force-pushed the fix-140025 branch from 7efcdd5 to 21014aa Compare January 2, 2026 09:08

📜🤖 Added by blurb_it.

de68f62

colesbury self-requested a review January 2, 2026 18:09

colesbury reviewed Jan 2, 2026

View reviewed changes

picnixz reviewed Jan 2, 2026

View reviewed changes

Aniketsy and others added 4 commits January 3, 2026 11:54

Update Lib/test/test_queue.py

654673a

Co-authored-by: Sam Gross <colesbury@gmail.com>

Update Misc/NEWS.d/next/Library/2026-01-02-09-32-43.gh-issue-140025.z…

de5b4c7

…OX58_.rst Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Update Modules/_queuemodule.c

9e67b66

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

implement __sizeof__ for SimpleQueue to account for ring-buffer storage

034a9cd

picnixz approved these changes Jan 3, 2026

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting review labels Jan 3, 2026

picnixz reviewed Jan 3, 2026

View reviewed changes

Comment thread Misc/NEWS.d/next/Library/2026-01-02-09-32-43.gh-issue-140025.zOX58_.rst Outdated

Update Misc/NEWS.d/next/Library/2026-01-02-09-32-43.gh-issue-140025.z…

887af43

…OX58_.rst Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

kumaraditya303 approved these changes Jan 8, 2026

View reviewed changes

Merge branch 'main' into fix-140025

7ba914f

kumaraditya303 enabled auto-merge (squash) January 8, 2026 12:10

kumaraditya303 merged commit f3e069a into python:main Jan 8, 2026
46 checks passed

bedevere-app Bot removed the awaiting merge label Jan 8, 2026

reidenong pushed a commit to reidenong/cpython that referenced this pull request Jan 12, 2026

pythongh-140025: Fix queue.SimpleQueue.__sizeof__() to return corre…

989b887

…ct size (python#143137)

thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026

pythongh-140025: Fix queue.SimpleQueue.__sizeof__() to return corre…

fff9b52

…ct size (python#143137)

Uh oh!

Conversation

Aniketsy commented Dec 24, 2025 • edited by colesbury Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

colesbury left a comment

Choose a reason for hiding this comment

Uh oh!

colesbury Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

colesbury Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

colesbury Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

Aniketsy commented Dec 24, 2025

Uh oh!

picnixz commented Dec 25, 2025

Uh oh!

Aniketsy commented Jan 2, 2026

Uh oh!

colesbury left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

colesbury Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

Aniketsy Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

picnixz Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

Aniketsy Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Jan 8, 2026

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Aniketsy commented Dec 24, 2025 •

edited by colesbury

Loading