gh-140025: Fix queue.SimpleQueue.__sizeof__() to account for buffer#143277
Closed
ayushm98 wants to merge 1 commit intopython:mainfrom
Closed
gh-140025: Fix queue.SimpleQueue.__sizeof__() to account for buffer#143277ayushm98 wants to merge 1 commit intopython:mainfrom
ayushm98 wants to merge 1 commit intopython:mainfrom
Conversation
Fixes python#140025 The __sizeof__() method for queue.SimpleQueue previously ignored the underlying RingBuf data structure, only returning the basic object size. Now properly accounts for the dynamically allocated items array in the RingBuf, which grows with the queue capacity: - Returns base object size + (items_cap * sizeof(PyObject*)) This gives accurate memory usage for SimpleQueue instances.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
The following commit authors need to sign the Contributor License Agreement: |
Member
StanFromIreland
left a comment
There was a problem hiding this comment.
You need to add tests, a blurb and sign the CLA.
Member
|
There is already an open PR: #143137. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #140025
Summary
The
__sizeof__()method forqueue.SimpleQueuenow properly accounts for the dynamically allocated internal buffer.Problem
Previously,
SimpleQueue.__sizeof__()only returned the basic object size, ignoring the underlyingRingBufdata structure that holds the queued items.Solution
Implemented a custom
__sizeof__()method that includes:items_cap * sizeof(PyObject*)Example
Changes
simplequeue_sizeof()function inModules/_queuemodule.c__sizeof__tosimplequeue_methodsarrayqueue.SimpleQueue.__sizeof__()ignores the underlying data structure #140025