gh-137153: Add latin_N aliases to encodings.aliases#136701
gh-137153: Add latin_N aliases to encodings.aliases#136701malemburg merged 3 commits intopython:mainfrom
latin_N aliases to encodings.aliases#136701Conversation
|
I don't think this will work (and I'm surprised that the email package's test still pass): The Also note that the encoding package's aliases refer to module names used in the package and not necessarily widely accepted encoding names used in email, e.g. "iso-8859-1" is commonly used in email, but not "iso8859_1". |
malemburg
left a comment
There was a problem hiding this comment.
See my comments on the issue. I don't think this is a good way to "reuse" the encoding packages aliases dictionary.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I withdraw my attempt on the email module, I will reuse this pr/branch to add just the aliases. |
encodings.aliases in email modlatin_N aliases to encodings.aliases
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @malemburg: please review the changes made to this pull request. |
|
Anything left to do here before this can be merged? |
|
Thanks, @StanFromIreland |
Requesting Marc since
encodings.aliaseshas been updated, no rush, this can wait till you have time.latin_Ncodecs aliases toencodings.aliases#137153