Mark test_embeddable as xfail on MinGW - #10067
Merged
Merged
Conversation
radarhere
changed the title
radarhere
marked this pull request as draft
September 27, 2026 14:30
Member
|
Yep, let's do either skipif or xfail for now. |
radarhere
marked this pull request as ready for review
September 28, 2026 02:32
hugovk
enabled auto-merge (squash)
September 28, 2026 05:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the latest update of the runner-image,
test_embeddablehas started failing on MinGW in main - https://github.com/python-pillow/Pillow/actions/runs/36274049311/job/108493249802However, the test wasn't passing before this either. It was being skipped with 'Compiler could not be initialized' - https://github.com/python-pillow/Pillow/actions/runs/36122556591/job/108031205104#step:6:9274
The simplest option is to mark it as xfail.