Skip to content

fix: fail the build if the SDK renumbers a probed display controller #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prokrypt merged 1 commit into from
Nov 11, 2026
Merged

fix: fail the build if the SDK renumbers a probed display controller #623

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/platform/PanelProbe.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,14 @@ constexpr char NVS_NAMESPACE[] = "panel";
constexpr char NVS_KEY[] = "probe";
constexpr uint8_t RECORD_VERSION = 1;

// The record keeps controllers as raw enum values, so an SDK renumber would boot a
// stale record into the wrong driver. Pin the values the probe can store; if one
// fails, bump RECORD_VERSION (forces one re-probe) and update the pin.
using Controller = BoardConfig::DisplayController;
static_assert(static_cast<uint8_t>(Controller::SSD1677) == 0 && static_cast<uint8_t>(Controller::UC8253) == 2 &&
static_cast<uint8_t>(Controller::UC8279) == 6 && static_cast<uint8_t>(Controller::UC8179) == 7,
"DisplayController renumbered: bump RECORD_VERSION");

struct Record {
uint8_t version;
uint8_t board;
Expand Down