Repository navigation
fix: fail the build if the SDK renumbers a probed display controller - #623
Merged
Merged
Conversation
The panel probe record in NVS keeps DisplayController as raw values. An SDK renumber would load a stale record into the wrong driver until the recovery chord. A static_assert pins the values the probe can store, so a renumber breaks the build and the fix is a RECORD_VERSION bump. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QrEdpxLkuVrifx7ahhZV13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Clankmaster · project thread
Review finding:
src/platform/PanelProbe.cppstoresBoardConfig::DisplayControllerin NVS as a raw value. An SDK renumber would load a stale record into the wrong driver until the recovery chord.Fix: a
static_assertpins the values the probe can store (SSD1677 0, UC8253 2, UC8279 6, UC8179 7). A renumber now breaks the build with "bump RECORD_VERSION", which forces one re-probe. Zero runtime cost, no NVS format change.Not needed:
boardanddefaultControllerare compared, not trusted, so a renumber there only re-probes; the diag blob is size-checked and diagnostics only.Hardware check: none needed (compile-time only); X4 Pro boot log still shows the panel from "saved probe (NVS)".
No changelog: compile-time guard, no user-visible change.
Generated by Claude Code