Skip to content

Validate signature length to prevent OOB read #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkannwischer merged 1 commit into from
Jun 11, 2026
Merged

Validate signature length to prevent OOB read #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions slh_dsa.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,6 +688,10 @@ int slh_verify_internal(const uint8_t *m, size_t m_sz, const uint8_t *sig,
slh_var_t var;
uint8_t digest[SLH_MAX_M];

if (sig_sz != slh_sig_sz(prm))
{
return 0; /* false */
}
/* use Hmsg directly */
prm->mk_var(&var, pk, NULL, prm);
prm->h_msg(&var, digest, sig, m, m_sz, NULL, SLH_CTX_SZ_NO_CONTEXT);
Expand All @@ -710,6 +714,11 @@ int slh_verify(const uint8_t *m, size_t m_sz, const uint8_t *sig, size_t sig_sz,
return 0; /* false */
}

if (sig_sz != slh_sig_sz(prm))
{
return 0; /* false */
}

/* create the "pure" hash (with context) */
prm->mk_var(&var, pk, NULL, prm);
prm->h_msg(&var, digest, sig, m, m_sz, ctx, ctx_sz);
Expand Down
Loading