Repository navigation
Validate signature length to prevent OOB read - #48
Merged
Merged
Conversation
Signed-off-by: Loganaden Velvindron <logan@cyberstorm.mu>
mkannwischer
approved these changes
Jun 10, 2026
mkannwischer
left a comment
mkannwischer
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks @loganaden!
Contributor
|
I am not sure what's happening with the CI - the Github runners don't seem to be picking up the jobs. |
2 tasks
Ramya-9353
added a commit
to Ramya-9353/liboqs
that referenced
this pull request
Oct 11, 2026
Per review, take the upstream fix for the out-of-bounds read (pq-code-package/slhdsa-c#48, merged as d25ccc6) by bumping the pinned commit in copy_from_slh_dsa_c.py and dropping verify_bounds.patch. The regenerated slh_dsa_c tree also picks up upstream CBMC contract annotations and a sha3_init cleanup; no algorithm behaviour changes. The short-signature regression test in tests/test_sig.c is kept and passes under ASan. Signed-off-by: Ramya Eliger <ramya@digiscrypt.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.