Skip to content

mediad: lower the frame rate on a weak link, never the resolution #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FabienDanieau wants to merge 1 commit into
base: main
Choose a base branch
from
Open

mediad: lower the frame rate on a weak link, never the resolution #431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions mediad/src/pipeline.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,6 +596,12 @@ pub fn start(

set_congestion_control(&sink, congestion_control);

// A weak link drops the frame rate, never the resolution. Lowering the resolution puts a
// software `videoscale` in front of `mpph264enc`, and a system-memory frame into
// `mpph264enc` is what oopsed the board kernel twice; `videorate` only drops frames, so the
// camera's buffers still reach the encoder untouched.
sink.set_property_from_str("enable-mitigation-modes", "downsampled");

// The encoder settings, applied through the hook that exists for it.
//
// Handing `webrtcsink` the encoder would otherwise *lose* them, which would make this change a
Expand Down
Loading