Skip to content

ci: use pnpm 11 for pr-check - #284

Merged
zkochan merged 1 commit into
pnpm:masterfrom
jamietanna:ci/bump
Aug 3, 2026
Merged

ci: use pnpm 11 for pr-check#284
zkochan merged 1 commit into
pnpm:masterfrom
jamietanna:ci/bump

Conversation

@jamietanna

@jamietanna jamietanna commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Noticed while working on #283.

Summary by CodeRabbit

  • Chores
    • Updated the build validation environment to use pnpm version 11, ensuring distribution checks run with the latest configured package manager version.

Noticed while working on pnpm#283.
@jamietanna
jamietanna requested a review from zkochan as a code owner August 3, 2026 08:54
@jamietanna jamietanna mentioned this pull request Aug 3, 2026
2 tasks
@jamietanna

Copy link
Copy Markdown
Contributor Author

(I see there's a renovate.json but the repo isn't installed on the Renovate app - if you add it, you'll get automagic bumps for this, too!)

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0ec1c6b2-ebf5-453d-9a69-e58ec56c36f5

📥 Commits

Reviewing files that changed from the base of the PR and between 769ae71 and 8a0787d.

📒 Files selected for processing (1)
  • .github/workflows/pr-check.yaml
📜 Recent review details
🔇 Additional comments (1)
.github/workflows/pr-check.yaml (1)

22-22: LGTM!


📝 Walkthrough

Walkthrough

The pull request workflow now sets up pnpm version 11 before building and checking dist/index.js.

Changes

CI workflow

Layer / File(s) Summary
Update pnpm setup version
.github/workflows/pr-check.yaml
The workflow changes the pnpm setup action from version 9 to version 11.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: zkochan

Poem

A bunny checks the workflow line,
“pnpm eleven now will shine.”
The build hops on, the checks run bright,
With fresh tooling set just right.
One small change, a cleaner flight.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely states that the pr-check CI workflow now uses pnpm 11.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

CI: bump pnpm to v11 in pr-check workflow

⚙️ Configuration changes 🕐 Less than 5 minutes

Grey Divider

AI Description

• Update pr-check GitHub Actions workflow to install pnpm v11.
• Reduce CI/tooling drift when building and verifying dist artifacts.
High-Level Assessment

The following are alternative approaches to this PR:

1. Use Corepack with packageManager from package.json
  • ➕ Single source of truth for pnpm version across local dev and CI
  • ➕ Avoids needing to update workflow when pnpm version changes
  • ➖ Requires ensuring Corepack is enabled and supported in the runner image
  • ➖ Still may need explicit Node/Corepack setup steps depending on environment
2. Pin pnpm via .npmrc/.tool-versions (asdf) and reference in CI
  • ➕ Centralizes tool versions outside workflow files
  • ➕ Easier multi-tool version management if the repo standardizes on one approach
  • ➖ Adds another config convention/tooling dependency
  • ➖ Still needs CI wiring to read/apply the version

Recommendation: The current approach (explicitly pinning pnpm in the workflow) is the simplest and lowest-risk for an immediate CI fix. If pnpm version changes are expected to be frequent, consider moving version ownership to package.json via Corepack to reduce duplication and drift.

Files changed (1) +1 / -1

Other (1) +1 / -1
pr-check.yamlBump pnpm version from 9 to 11 for pr-check +1/-1

Bump pnpm version from 9 to 11 for pr-check

• Updates the pnpm/action-setup step to install pnpm v11 instead of v9. This ensures the build step runs with the intended pnpm major version in CI.

.github/workflows/pr-check.yaml

@zkochan
zkochan merged commit 75677f7 into pnpm:master Aug 3, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants