Repository navigation
fix(web): message timestamps follow a system time zone change #32371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
juliusmarminge
wants to merge
5
commits into
main
Choose a base branch
from
fix/issue-32355
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+113
−22
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
d750a75
test(web): message timestamps follow a time zone change (reproduces #…
juliusmarminge 2b2fc8c
fix(web): message timestamps follow a system time zone change
juliusmarminge 65b3056
test(web): derive expected time zone labels from the host locale
juliusmarminge 0312d9f
Merge remote-tracking branch 'origin/main' into fix/issue-32355
juliusmarminge 982a6a5
fix(mobile): message time follows the zone Intl reports, not Hermes's…
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refresh visible rows when the time zone changes.
If the device time zone changes while a thread remains open, this check runs only when a message row renders. Existing visible labels can retain the old time zone because the change does not invalidate the list. Refresh the feed on foreground return or a time-zone notification, and include the resolved zone in the list’s
extraData. Add a mobile regression case that changes the resolved zone without changing the messages. (raw.githubusercontent.com)As per coding guidelines, “Test behavior that can break” includes “the logic a bug fix changed.”
Source: Coding guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not changing this here. This PR fixes the stale formatters, so every label renders in the current zone the next time its row renders, on web and mobile alike. Re-rendering rows already on screen when the zone changes would need a new foreground or zone-change listener plus list invalidation. That is a separate behaviour change, and it is left to the maintainers to decide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juliusmarminge Understood. The PR leaves automatic refresh of visible rows to a separate decision.
The existing mobile review guidance calls for an iOS and Android check: change the device time zone, then re-render a message without restarting the app. The PR reports a Node check, but not a device check.
Would you like me to open a follow-up issue for refreshing visible rows?
Learnings used
You are interacting with an AI system.