Skip to content

fix(web): the Fix action on a thread details PR row stays inside the card - #31115

Open
pouyarezvani wants to merge 2 commits into
pingdotgg:mainfrom
pouyarezvani:fix/thread-details-pr-row-overflow
Open

pouyarezvani wants to merge 2 commits into
pingdotgg:mainfrom
pouyarezvani:fix/thread-details-pr-row-overflow

Conversation

@pouyarezvani

Copy link
Copy Markdown

Problem

On a watched pull request whose checks show a count, the thread details row's metadata line (#number, "16/17 checks", the watch icon and the trailing action) is wider than the 280px card. Every control on that line is shrink-0 and whitespace-nowrap, so nothing gives way and the card clips the Fix action at its right edge. Longer counts, or the "Preparing..." label after clicking Fix, clip it further.

Closes #31113.

Change

On this row, the checks count control can shrink (min-w-0 shrink, which cn resolves over the control's shrink-0), and the count label truncates with an ellipsis. When space runs out, the label gives way and the trailing action (Fix, Merge, Resolve, Ready or its pending label) stays fully visible. variant="count" is only used by this row, so other checks badges are unchanged.

Scope and approval

A very small, focused fix for an obvious layout bug: an action button clipped by its container. It changes two class lists and no behavior. Reported in #31113.

Verification

  • Reproduced in 0.1.8-nightly.20261104.4179 (macOS desktop app). The card's edge cuts through Fix:

    Fix clipped at the card edge in nightly 4179

  • Before and after: I rendered the row's markup with its exact Tailwind classes at the card's 280px width (Tailwind 4, dark theme tokens), merging conflicting classes the way cn does. "Before" matches the nightly. "After" keeps Fix and "Preparing..." inside the card, and the count truncates instead:

    Before and after renders of the thread details PR row

  • Ran tailwind-merge 3.4.0 with the app's extendTailwindMerge config: cn(<meta control classes>, "min-w-0 shrink") drops shrink-0 and keeps min-w-0 shrink.

  • Not checked: I did not run the dev app or vp run check:changed, because dependencies were not installed in this checkout. As a purely visual fix, it ships with captures and no test, per AGENTS.md.

Written by Claude Opus 5.5 in Claude Code, running inside T3 Code.

🤖 Generated with Claude Code

…card

On a watched pull request whose checks show a count, the row's metadata
line (number, checks count, watch icon, trailing action) is wider than
the 280px thread details card. Every control on it is shrink-0 and
nowrap, so the card clipped the Fix action at its right edge.

The checks count control now shrinks and its label truncates, so the
trailing action always stays fully visible.

Closes pingdotgg#31113

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Nov 4, 2026
@macroscopeapp

macroscopeapp Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 4e8f78a

Macroscope's review found this PR approvable — The checks label can shrink and truncate so the Fix action stays inside the thread PR card. This is a localized presentation change with existing actions and check details unchanged.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 4e8f78a and 2c745e7.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

No actionable comments were generated in the recent review.

Walkthrough

The checks control in the thread details PR row can shrink within its flex row. The completed/total and failed checks labels can shrink and truncate. Their displayed values and render conditions are unchanged.

Changes: PR row width handling

Layer / File(s) Summary
Checks row layout
apps/web/src/components/pullRequest/PullRequestChecksPopover.tsx, apps/web/src/components/chat/ThreadDetailsPrRow.tsx
The completed/total and failed count labels gain min-w-0 truncate. The checks control gains min-w-0 shrink.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix · Severity of issue fixed: Low

Possibly related issues

Possibly related PRs

Suggested labels: bugfix, size:XS

Suggested reviewers: t3dotgg

Merge Risk: Minimal · previous review 4e8f7

The layout change is limited to allowing the checks metadata to shrink and truncate, with no identified regression.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title is concise, uses the repository's conventional format, and clearly identifies the layout fix for the Fix action in the thread details PR row.
Description check Passed The description includes Problem, Change, Scope and approval, and Verification sections. It explains the layout issue, the focused fix, linked issue, before-and-after UI evidence, validation performed…
Linked Issues check Passed Issue [#31113] requires the Fix action to remain inside the 280px thread details card. ThreadDetailsPrRow.tsx now passes min-w-0 shrink to the checks count control. PullRequestChecksPopover.tsx …
Out of Scope Changes check Passed The pull request changes two focused class lists in ThreadDetailsPrRow.tsx and PullRequestChecksPopover.tsx. Both changes directly support the overflow fix in issue [#31113]. No unrelated behavior…
Full details: Description check

Explanation

The description includes Problem, Change, Scope and approval, and Verification sections. It explains the layout issue, the focused fix, linked issue, before-and-after UI evidence, validation performed, and checks not run.

Full details: Linked Issues check

Explanation

Issue [#31113] requires the Fix action to remain inside the 280px thread details card. ThreadDetailsPrRow.tsx now passes min-w-0 shrink to the checks count control. PullRequestChecksPopover.tsx now applies min-w-0 truncate to the count labels. The count can give way while the trailing action remains visible. The changes preserve the existing count conditions and action behavior. Issue [#31113] states no automated-test requirement.

Full details: Out of Scope Changes check

Explanation

The pull request changes two focused class lists in ThreadDetailsPrRow.tsx and PullRequestChecksPopover.tsx. Both changes directly support the overflow fix in issue [#31113]. No unrelated behavior, public API, or other checks badge variant changes are shown in the pull request diff.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 7f6f47b and 4e8f78a.

Files selected for processing: 2

  • apps/web/src/components/chat/ThreadDetailsPrRow.tsx
  • apps/web/src/components/pullRequest/PullRequestChecksPopover.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

@maria-rcks

Copy link
Copy Markdown
Collaborator

Note

Written by claude-opus-5-5 on behalf of Maria

Takeover update. The fix itself is unchanged.

  • Merged current main (298cb24) into the branch with a merge commit. No conflicts.
  • The earlier Test Web failure was AddEnvironmentDialog.browser.test.tsx > clears the form after dismissing it on SSH, a click timeout in a file this PR does not touch. It passed 3/3 on a fresh run, and main is green.
  • vp run check:changed passes: format, lint, knip, typecheck, tests, react compiler.

Real ThreadDetailsPrRow with the app stylesheet, rendered at the card's 280px width with 16/17 checks, one failure and the watch icon:

Before (main): Fix is clipped at the card edge.

Before: thread details PR row on main, Fix action clipped at the right edge of the 280px card

After (this PR): the count truncates and Fix stays inside the card.

After: thread details PR row with this PR, checks count truncated and Fix fully visible

@juliusmarminge juliusmarminge added bugfix Fix PR opened by an issue lead; enters the PR loop pr:gate-failed A land gate failed labels Nov 5, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fix PR opened by an issue lead; enters the PR loop pr:gate-failed A land gate failed size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Fix action on a thread details PR row overflows the card

3 participants