Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a small window, the Changes toolbar keeps its view controls in a non-shrinking row. At a 320px viewport the panel is 281px wide but its contents occupy 311px, pushing the file-tree button offscreen. The PR Code toolbar already has a compact menu, but leaves collapse, test-file filtering and the file tree outside it.
Use one shared Diff options menu below 36rem of toolbar width. It contains line wrapping, whitespace filtering, stacked/split layout, collapse/expand, test-file filtering and the file tree, with the existing conditional availability and state handlers. Wider toolbars retain their inline controls; resizing preserves the selected settings. Named CSS container queries follow the panel width without a resize observer or new persisted state.
Prior-work check: searched upstream and fork issues, PRs and discussions for diff toolbar/options, clipping, overflow and narrow windows. No direct matching fix found. Upstream #32603 changes PR section-tab labels, #32593 changes pane-tab scrolling (both target redesign branches), and #31115 fixes the thread-details PR row. These are separate surfaces. This change extends the existing compact PR diff-menu approach to all view options and the Changes panel.
Validation:
vp run check:changedpassed format, lint, both knip passes, affected web/scripts typechecks, 8 existing tests, and React Compiler checks. The final restored code matched the passing check cache. Commit hooks passed.Web and desktop share these components; native mobile uses its own UI and is unchanged. No entry-point, provider, RPC, permission, server or remote-origin changes. Electron shell, native mobile and real relay/tunnel sessions were not run. CI and reviews are separate from the local checks. No live T3 data was modified.
Captures use the same isolated dev environment; Changes shows the working-tree patch, so its diff totals vary while swapping baseline/final renderer files. Screenshot assets are hosted in a non-latest evidence prerelease and are not committed to the source tree.
Model/harness: gpt-6-astra, Codex in T3 Code.