Repository navigation
Conversation
github-actions Bot
added a commit
to citizenadam/desloppify
that referenced
this pull request
Oct 11, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Queue surfaces can disagree when the configured strict-score target is below 100, and commands with an explicit nested state file can read or mutate another language's root plan.
Pass runtime config into the plan queue context, resolve execution/backlog thresholds consistently, and scope default plan persistence to the explicit state file for one command. Preserve explicit non-default threshold overrides and explicit plan paths. No persisted format migration.
Evidence
nextselects the finding while plan/footer request the assessment. Four of six threshold regression cases fail.After: All six pass; next/plan/footer agree and leave their inputs unchanged. Exact fixture:
tests/commands/test_queue_target_contract.py::test_next_plan_queue_and_footer_share_configured_target.next --state .desloppify/typescript/state-typescript.jsonandplan --state .desloppify/typescript/state-typescript.json queueread the root plan;plan ... resetwrites it. Three of four CLI regression cases fail.After: All four pass, including sibling backup preservation and context cleanup between CLI invocations. Exact fixture:
tests/commands/test_explicit_state_plan_context.py.nextandplan queueagainst existing project state, with the same explicit state path, now agree on the nested plan's 20 unassessed dimensions and do not inherit the root plan's 17 ordered entries or 189 skips. Both language state files, both plans and config were verified byte-for-byte unchanged. Existing scan-data replay also confirms target-85 selection and footer agreement.nextboth completed with exit 0, respecting the selected scope and exclusions. This verifies the actual workflow; it does not claim coverage from unavailable external detectors.python -B -m pytest desloppify/tests/ -qresult is 5,854 passed, 70 failed, 4 skipped. The exact 70 failures also occur on its unmodified base: 55 explicit grammar-download DNS errors and 15 base-reproduced parser assertions. Full-suite success remains unverified in this environment.main; 197 focused tests and Ruff pass. Its full suite is 5,751 passed, 70 failed, 4 skipped. Re-running all 70 failed node IDs on this exact unmodified upstream base reproduces the identical set, including 55 download-DNS failures. The integration test count differs because that checkout includes a separate pending PR's tests. Full-suite success remains unverified here.Merge Danger
Door: Two-way
No state migration. The plan-path override lasts for one CLI runtime invocation.
Blast Radius: Queue
Default execution/backlog assessment gating follows the resolved target. Commands with an explicit state file now default plan reads, writes and locks to its sibling plan.