Repository navigation
Conversation
github-actions Bot
added a commit
to citizenadam/desloppify
that referenced
this pull request
Oct 11, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
An ordinary
plan skip <id> --false-positive --note ... --attest ...can survive one scan and reopen on the next matching scan, even when the source has not changed. Skipping removes the ID from the queue but retains cluster membership. Scan reconciliation restores the FP status, then supersedes its non-actionable cluster reference and deletes the skip entry. The following scan has no disposition to restore.The same cleanup discards permanent skips. An ordinary re-skip cannot repair an affected FP durably because the old superseded tombstone deletes the new skip before status synchronization. This occurs in active and inactive clusters and is independent of explicit language selection.
Fix
Detach deliberate permanent/false-positive dispositions from queue, promoted IDs, cluster members, and step references while preserving their skip evidence. Clear an earlier superseded tombstone when a present finding has an explicitly restored durable skip. Keep existing superseding behavior for missing findings and unskipped resolved work.
The change is confined to scan-plan reconciliation and its regression tests. It does not add source fingerprints, config exclusions, review imports, or score overrides.
Validation
git diff --checkalso pass.95205c1ebase, whose result is 5,854 passed / 70 failed / 4 skipped. Fifty-five base failures explicitly concern parser grammar-download DNS; 15 parser assertions also reproduce on the base. Full-suite success remains unverified in this environment.main(3a7735d5). Its 121 focused tests and Ruff pass; the full suite reports 5,761 passed, 70 failed, 4 skipped. The exact 70 failed node IDs match the already reproduced failures on that exact unmodified upstream base. Integration and upstream pass counts differ because the integration checkout contains separate pending tool fixes; this PR excludes them.nextcommands exit0 in an owned coherent source snapshot of the project that exposed the bug. The scans redetect 67 and 68 accepted findings, respectively, while retaining all 124 FP statuses and original skip records, with zero superseded dispositions. The unchanged sample module is detected in both scans. The 846 archived source files preserve their accepted Git hashes; canonical scanner files remain byte unchanged. The snapshot uses an explicit isolated state path and an attested--force-rescansolely to exercise repeated scans outside the canonical queue. PHPStan reports reduced coverage and jscpd exits with errors, so neither PHPStan nor duplication coverage is claimed. The tested reconciliation source is byte-identical to this PR's source; no external review or score override was used.This PR contains only the reconciliation fix; the separate queue-target/state-path PR #835 remains unchanged.