Repository navigation
Conversation
playb0t
requested review from
AlaaShaker,
dustin-sale,
gebhardtr,
irfan-ahmed,
krisrice and
robander
as code owners
November 2, 2026 19:04
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
This was referenced Nov 2, 2026
Open
Generated-by: Codex:gpt-6.1-sol Signed-off-by: Alex Gercog <w0rldlogic.0point@proton.me>
playb0t
force-pushed
the
541-podman-network-cleanup
branch
2 times, most recently
from
November 5, 2026 11:42
bb38b31 to
6f5d575
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Podman 5.7.0 has no
--ignoreflag onpodman network rm, so every execution ended inisolation provider cleanup failedand left its network. The provider now:podman network exists <name>and accepts only exit 0 (present) or 1 (absent);podman network rm <name>, without--forceor--ignore;runPodmannow returns the exit code and takes an explicit list of successful codes; existing callers keep the default[0]. The fake Podman in the tests acceptsnetwork existsandnetwork rm <name>instead of asserting--ignore.Fixes #541
Overlap: #431 changes the same files (
podman.ts, the tests, the CHANGELOG) and still callsnetwork rm --ignore; #495 shares the CHANGELOG and the sandbox tests. A textual conflict in the CHANGELOG is likely whichever merges first; I will rebase.Type of change
How Has This Been Tested?
test/sandbox.test.ts(network present; already absent;existsexit 125; removal fails while the network is still present; the network disappears between check and removal; a failed re-check): all six fail on the unchanged provider and pass with this change.maine75013f9: 161 passed, 0 failed, 0 skipped; line coverage 94.07%.buf generate,tsc -p tsconfig.build.jsonandtsc --noEmitpass.bc096453; the files it exercises are byte-identical one75013f9.To verify:
Test Configuration:
Not run: other Podman versions, other operating systems, the Moon wrapper.
Checklist: