Repository navigation
Conversation
playb0t
requested review from
AlaaShaker,
dustin-sale,
gebhardtr,
irfan-ahmed and
krisrice
as code owners
November 2, 2026 19:07
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
Generated-by: Codex:gpt-6.1-sol Signed-off-by: Alex Gercog <w0rldlogic.0point@proton.me>
Generated-by: Codex:gpt-6.1-sol Signed-off-by: Alex Gercog <w0rldlogic.0point@proton.me>
playb0t
force-pushed
the
546-podman-cleanup-deadline
branch
2 times, most recently
from
November 5, 2026 11:42
6ded9b3 to
836edd2
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Depends on #544; this branch is on top of it.
Cleanup commands now share one 5 s budget, which leaves 1 s under the sandbox's 6 s outer guard to join killed children. Each command gets the smaller of its own 5 s limit and what is left of the budget; once the budget is spent, no further cleanup command starts and cleanup reports a failure. A timed-out command is killed and its promise settles on
close, so the caller cannot move on while the CLI is alive. On POSIX the CLI runs in its own process group and the existingkillChildTreehelper kills the group.The README's host section now describes the budget, and says that an exhausted budget is a cleanup failure that can leave resources for operator recovery.
Fixes #546
Trade-off to decide: the 5 s budget can reject a cleanup that used to succeed between 5 and 6 s. If you prefer another split under the guard, it is the two constants at the top of
podman.ts.Overlap: #431 adds a shared cleanup-deadline contract of its own (
cleanupDeadlineMs→terminate), with an immediate timeout rejection and a direct-child kill; the two need to be reconciled if both land. #495 shares the CHANGELOG, the README and the sandbox tests.Type of change
How Has This Been Tested?
test/sandbox.test.tsfail before the change and pass after it.maine75013f9: 163 passed, 0 failed, 0 skipped; line coverage 94.06%.buf generate,tsc -p tsconfig.build.jsonandtsc --noEmitpass.bc096453; the files they exercise are byte-identical one75013f9:42in both;network rmCLI still alive; after, no cleanup CLI was alive at the reply, and the network was left for explicit recovery, reported as a cleanup failure;timed_out: truein both;Test Configuration:
Not run: Windows (no process group), D-state processes, a failing kill, other Podman versions, the Moon wrapper.
Checklist: