Skip to content

luci-proto-wireguard: download current peer configuration #8966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dhrm1k wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −2
Open

luci-proto-wireguard: download current peer configuration #8966

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0701784
luci-proto-wireguard: download current peer configuration
dhrm1k Sep 22, 2026
73b24a2
luci-proto-wireguard: lint fix
dhrm1k Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions protocols/luci-proto-wireguard/htdocs/luci-static/resources/protocol/wireguard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ function validateBase64(section_id, value) {
if (value.length == 0)
return true;

if (value.length != 44 || !value.match(/^(?:[A-Za-z0-9+\/]{4})*(?:[A-Za-z0-9+\/]{2}==|[A-Za-z0-9+\/]{3}=)?$/))
if (value.length != 44 || !value.match(/^(?:[A-Za-z0-9+/]{4})*(?:[A-Za-z0-9+/]{2}==|[A-Za-z0-9+/]{3}=)?$/))

@openwrt-ai openwrt-ai Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this no-useless-escape cleanup is unrelated to the download fix the commit message describes, leaving an undocumented hunk. Either mention it in the commit body or split it into its own commit.

Generated by Claude Code

@systemcrash systemcrash Sep 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, please put this in a separate commit with a subject line like:

luci-proto-wireguard: lint fix

return _('Invalid Base64 key string');

if (value[43] != "=" )
Expand Down Expand Up @@ -816,7 +816,8 @@ return network.registerProtocol('wireguard', {
'click'(ev) {
ev.preventDefault();

const blob = new Blob([peer_config], { type: 'text/plain' });
const current_config = node.querySelector('.client-config').textContent;
const blob = new Blob([current_config], { type: 'text/plain' });
const url = URL.createObjectURL(blob);
const a = document.createElement('a');

Expand Down
Loading