Conversation
openwrt
Bot
added
the
not following guidelines
dhrm1k
force-pushed
the
fix/wireguard-peer-config-download
branch
from
August 23, 2026 05:30
00b9ac7 to
0363a9e
Compare
openwrt
Bot
removed
the
not following guidelines
openwrt-ai
reviewed
Aug 23, 2026
Member
|
@dhrm1k Can you take a look, why the CI/CD fails for you in this case? Output: |
dhrm1k
force-pushed
the
fix/wireguard-peer-config-download
branch
from
September 16, 2026 20:32
0363a9e to
cacb550
Compare
Author
|
@BKPepe, found it. The ESLint job lints the whole changed file, not just the diff, so it flagged three pre-existing / escapes in the Base64 regex. Removed them and amended the commit. |
dhrm1k
force-pushed
the
fix/wireguard-peer-config-download
branch
from
September 16, 2026 20:54
cacb550 to
fdc366e
Compare
openwrt-ai
reviewed
Sep 17, 2026
| return true; | ||
|
|
||
| if (value.length != 44 || !value.match(/^(?:[A-Za-z0-9+\/]{4})*(?:[A-Za-z0-9+\/]{2}==|[A-Za-z0-9+\/]{3}=)?$/)) | ||
| if (value.length != 44 || !value.match(/^(?:[A-Za-z0-9+/]{4})*(?:[A-Za-z0-9+/]{2}==|[A-Za-z0-9+/]{3}=)?$/)) |
Collaborator
There was a problem hiding this comment.
nit: this no-useless-escape cleanup is unrelated to the download fix the commit message describes, leaving an undocumented hunk. Either mention it in the commit body or split it into its own commit.
Generated by Claude Code
Contributor
There was a problem hiding this comment.
yes, please put this in a separate commit with a subject line like:
luci-proto-wireguard: lint fix
The export preview is regenerated whenever its fields change, but the download button keeps using the configuration created when the dialog was opened. This can leave changes such as added DNS servers out of the downloaded file. Read the current preview when the download is requested so the file matches what LuCI displays. Signed-off-by: Dharmik Parmar <dharmikparmar2004@yahoo.com>
dhrm1k
force-pushed
the
fix/wireguard-peer-config-download
branch
from
September 22, 2026 03:24
fdc366e to
564f833
Compare
openwrt
Bot
added
the
not following guidelines
dhrm1k
force-pushed
the
fix/wireguard-peer-config-download
branch
from
September 22, 2026 03:26
564f833 to
ed88746
Compare
Fix the ESLint no-useless-escape errors reported by the CI by removing the unnecessary backslashes in front of the forward slashes inside the Base64 character class regex. Signed-off-by: Dharmik Parmar <dharmikparmar2004@yahoo.com>
dhrm1k
force-pushed
the
fix/wireguard-peer-config-download
branch
from
September 22, 2026 03:28
ed88746 to
73b24a2
Compare
openwrt
Bot
removed
the
not following guidelines
openwrt-ai
reviewed
Sep 22, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request details
Description
The WireGuard export preview is regenerated whenever its fields change, but the download button keeps using the configuration created when the dialog was opened. This can leave changes such as added DNS servers out of the downloaded file.
Read the current preview when the download is requested so the file matches what LuCI displays.
Fixes openwrt/packages#30358
Screenshot or video of changes (if applicable)
Not applicable. This changes the downloaded configuration rather than the visible layout.
Maintainer (preferred)
@danrl
Tested on
OpenWrt version: OpenWrt 25.12.2 (
r32802-f505120278)LuCI version: LuCI openwrt-25.12 branch (
26.082.75780~067535e)Web browser(s): Firefox 151.0.2
Tested on an x86/64 OpenWrt VM. After adding
9.9.9.9as a DNS server, the downloadedwireguard-peer.confexactly matched the updated preview and contained:DNS = 192.168.1.1, 9.9.9.9node --checkandgit diff --checkalso pass.Checklist