Repository navigation
feat: add video clip start and end times to course block data - #259
Closed
saraburns1 wants to merge 4 commits into
Closed
saraburns1 wants to merge 4 commits into
saraburns1 wants to merge 4 commits into
Conversation
Video blocks can be configured to play only a clip of the source video. The player reports positions against the full source video but the duration of only the clip, so Aspects needs the clip offsets to line them up. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
saraburns1
commented
Oct 8, 2026
Removed tests for video clip times serialization in XBlockSink.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes openedx/openedx-aspects#373
Description
In studio, video blocks can be set to play a portion of a video. In Aspects we currently only have the actual start/time of the original video with no information on what slice of video is shown to the user. This means that in the dashboard, a timestamp can show as 10:00.00 when the video shown in the course is only 2 minutes long.
This adds
video_start_timeandvideo_end_timetoxblock_data_jsonfor video blocks in thecourse_blockssink.Corresponding pr: openedx/aspects-dbt#179
Merge checklist:
🤖 Generated with Claude Code