Repository navigation
feat: generate videos that play a clip of the source video - #275
Closed
saraburns1 wants to merge 1 commit into
Closed
saraburns1 wants to merge 1 commit into
saraburns1 wants to merge 1 commit into
Conversation
About a quarter of generated videos now have a start and end time, like videos configured in Studio to play only part of the source video. As with the real video player, their events report the length of the clip but positions in the full source video, and their course block data includes video_start_time and video_end_time. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #275 +/- ##
==========================================
+ Coverage 85.54% 85.67% +0.12%
==========================================
Files 29 29
Lines 1986 2004 +18
Branches 175 175
==========================================
+ Hits 1699 1717 +18
Misses 260 260
Partials 27 27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Video blocks can be set to play only a clip of the source video (start/end time in Studio). The edx-platform video player then reports
lengthas the clip duration (endTime - startTime) buttimeagainst the full source video, which made Aspects show positions past the end of the video.This generates that case so load and test data cover it:
VIDEO_CLIP_*inconstants.py).video_start_timeandvideo_end_time(0.0 when not clipped), matching what the course block sink sends.Related:
Testing
🤖 Generated with Claude Code