Skip to content

docs: propose credential lifecycle and GitHub App access - #68

Open
freeqaz-openai wants to merge 18 commits into
mainfrom
docs/github-app-credentials
Open

freeqaz-openai wants to merge 18 commits into
mainfrom
docs/github-app-credentials

Conversation

@freeqaz-openai

@freeqaz-openai freeqaz-openai commented Sep 8, 2026 •

Copy link
Copy Markdown

What Problem This Solves

Enterprise Agents need repository access whose scope, approvals and cleanup survive turns and runtime replacement. Provider tokens alone cannot enforce an approved candidate, exact branch or original-work attribution.

Why This Change Was Made

Propose native Agent repository configuration and an Installation-selected CredentialGatewayDriver for mediation and credential lifecycle. Delivery starts with managed metadata, clone and fetch, then adds selected coding read workflows and exact-candidate Approve and publish. Any configured, authorized human may approve, including the requester; an Agent cannot. Independent-human approval and automatic authorization under explicit policy for bounded, allowlisted push/draft-PR operations are separate later modes. Broader durable Work and lifecycle controls follow the initial root work and subordinate helpers using the same scope.

User Impact

The proposed configuration and driver API are not implemented. The proposed GitHub profile keeps provider credentials outside Agent workloads and requires current online OCC authority for reads, writes and credential maintenance. Publication binds the candidate, refs, expected remote tip and PR metadata, preserving separate effect receipts and reconciling unknown outcomes without blind replay. Permission changes require fresh Pod/gVisor isolation; uncapped execution still uses finite leases.

This is a documentation proposal extending RFC 0027. It remains draft with a blank implementation issue pending acceptance.

Reading Guide

Evidence

  • Checked draft metadata, required sections, Markdown structure, links, anchors and whitespace; reran desktop/mobile rendering and independent cross-RFC review.
  • Desktop preview uses a local Markdown render with GitHub-style CSS.
  • Document checks only; provider, native runtime and deployment qualification require separate evidence.

@clawsweeper

clawsweeper Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper clawsweeper Bot added P2 Normal priority bug or improvement with limited blast radius. merge-risk: 🚨 security-boundary 🚨 Merging this PR could weaken sandboxing, authorization, credentials, or sensitive data. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. labels Sep 8, 2026
@clawsweeper

clawsweeper Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

Codex review: blocked before merge.

What this changes

This PR proposes managed GitHub repository access, protected credential lifecycle management, and staged human-approved publication for Enterprise Agents.

Example: An Agent has coding access to org/service and read access to org/library.

  • Before: The accepted Enterprise RFC does not specify repository selection or exact-candidate publication.
  • After: The proposal requires separate repository grants and human approval of the exact org/service candidate while denying publication to org/library.

Review scores

Measure Result What it means
Overall readiness 🦐 gold shrimp (3/6) Readable documentation with explicit implementation limits and no concrete findings; product acceptance remains unresolved.
Proof confidence 🐚 platinum hermit (4/6) ✨ media proof bonus Sufficient (screenshot): The committed desktop preview directly shows the added RFC's readable documentation and diagram; runtime and GitHub-provider behavior are expressly future implementation claims.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Product

Kind: Feature · Worth it: Needs a maintainer decision
User problem: Enterprise Agents need managed repository access whose permissions, publication approval, and cleanup remain attributable across turns and runtime replacement.
Reason: The proposal has clear potential value, but adds repository configuration and a credential Driver contract whose delivery scope has not been accepted.

Merge readiness

⛔ Blocked before merge - 1 item remains

Keep this PR open for RFC acceptance: it makes a distinct, coherent proposal absent from current main, and no concrete document defect was found.

Priority: P3
Reviewed head: 8c65dbb3d535d0805cd74cce5f6c368a82733106
Owner decision: Required. See Decision needed.

Decision needed

  • Question: Should this RFC require protected execution origin from stage A and exact-candidate human approval in stage B, or be revised toward the smaller Enterprise MVP?
  • Recommendation: Keep draft and align the MVP scope: Resolve the origin-protection and publication boundaries with the Enterprise area owner before recording RFC acceptance.
  • Why: These are new configuration, Driver, and publication contracts; no recorded acceptance settles them, and the closed Enterprise proposal describes different MVP boundaries.

Before merge

  • Resolve maintainer decision - Resolve the maintainer decision shown above before merge.

Findings

None.

Agent review details

How this fits together

The proposed credential gateway sits between Enterprise Agent Git clients and GitHub, consuming current OCC authorization and protected execution context before dispatching scoped requests with credentials held outside Agent execution.

flowchart LR
  Config[Administrator repository selection] --> OCC[OCC authorization]
  Agent[Agent Git client] --> Connector[Trusted execution connector]
  Connector --> Gateway[Proposed credential gateway]
  OCC --> Gateway
  Agent --> Publisher[Human approved publisher]
  Publisher --> Gateway
  Gateway --> GitHub[GitHub]
Loading

Technical review

Best possible solution:

Resolve the staged credential-access contract through RFC acceptance, then track implementation and runtime qualification separately.

Do we have a high-confidence way to reproduce the issue?

This is an explicitly unimplemented design proposal, so there is no reported runtime failure to reproduce.

Is this the best way to solve the issue?

The proposed ownership and qualification boundaries are coherent, but choosing their MVP scope requires an owner decision rather than a mechanical repair.

AGENTS.md: not found in the target repository.

Codex review notes: model internal, reasoning medium; reviewed against 967d9aac7472.

Security

None.

Evidence

What I checked:

Likely related people:

  • kevinlin-openai: Raw commit af708f0 adds rfcs/0027-openclaw-enterprise.md:355 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: af708f0ddb6f; files: rfcs/0027-openclaw-enterprise.md)

Review metrics

Metric Value Why it matters
Executable change surface Production +0; tests +0; 13 added documentation and diagram files The specification expands the proposed design without changing runtime behavior or persisted application state.

Labels

Label changes:

No label changes.

Label justifications:

  • P3: This is a design proposal awaiting acceptance, with no shipped runtime regression introduced.
  • rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🐚 platinum hermit and patch quality is 🐚 platinum hermit.
  • proof: sufficient: Contributor real behavior proof is sufficient.
  • proof: 📸 screenshot: Contributor real behavior proof includes screenshot evidence.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

History

Review history (19 earlier review cycles; latest 8 shown)
  • reviewed 2026-09-09T21:43:36.560Z sha 7dea5a4 :: needs real behavior proof before merge. :: none
  • reviewed 2026-09-11T07:48:03.154Z sha 265cc4f :: blocked before merge. :: none
  • reviewed 2026-09-11T19:11:16.301Z sha 0670aeb :: blocked before merge. :: none
  • reviewed 2026-09-11T19:31:12.142Z sha 3d79901 :: blocked before merge. :: none
  • reviewed 2026-09-14T21:59:39.919Z sha 3d79901 :: blocked before merge. :: none
  • reviewed 2026-09-14T22:42:33.907Z sha 8c65dbb :: blocked before merge. :: none
  • reviewed 2026-10-05T13:39:58.609Z sha 8c65dbb :: blocked before merge. :: none
  • reviewed 2026-10-11T13:45:50.815Z sha 8c65dbb :: blocked before merge. :: none

Reviewed October 14, 2026, 7:28 AM ET / 11:28 UTC (Revision 20).

@clawsweeper clawsweeper Bot added rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. and removed rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. labels Sep 8, 2026
@freeqaz-openai freeqaz-openai changed the title docs: propose scoped GitHub App access for Enterprise Agents RFC: credential lifecycle and GitHub App access Sep 8, 2026
@clawsweeper clawsweeper Bot removed the merge-risk: 🚨 security-boundary 🚨 Merging this PR could weaken sandboxing, authorization, credentials, or sensitive data. label Sep 8, 2026
@freeqaz-openai freeqaz-openai changed the title RFC: credential lifecycle and GitHub App access docs: propose credential lifecycle and GitHub App access Sep 9, 2026
@clawsweeper clawsweeper Bot added rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. and removed rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. labels Sep 9, 2026
@clawsweeper clawsweeper Bot added P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. and removed P2 Normal priority bug or improvement with limited blast radius. labels Sep 9, 2026
@clawsweeper clawsweeper Bot added proof: sufficient Contributor real behavior proof is sufficient. proof: 📸 screenshot Contributor real behavior proof includes screenshot evidence. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. and removed rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. labels Sep 11, 2026
@clawsweeper clawsweeper Bot added rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. and removed rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. labels Sep 11, 2026
@clawsweeper clawsweeper Bot added rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. and removed rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. labels Sep 14, 2026
@clawsweeper clawsweeper Bot added proof: sufficient Contributor real behavior proof is sufficient. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. and removed proof: sufficient Contributor real behavior proof is sufficient. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. proof: 📸 screenshot Contributor real behavior proof includes screenshot evidence. proof: sufficient Contributor real behavior proof is sufficient. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant