Repository navigation
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: blocked before merge. What this changesAdds a draft RFC for plugin update indicators across CLI inventory, update status, and Control UI using explicit refresh and shared observations. Example: An installed @openclaw/omniroute plugin receives a maintenance release.
Review scores
ProductKind: Feature · Worth it: Needs a maintainer decision Merge readiness⛔ Blocked before merge - 2 items remain Keep this PR open for a product decision: the draft RFC is absent from the default branch, remains paired with an open proposal by the same author, and has no concrete patch defect. Priority: P3 Decision needed
Before merge
FindingsNone. Agent review detailsHow this fits togetherThis repository records design decisions rather than runtime implementations; the proposed update owner would resolve recorded plugin sources and supply retained availability observations to CLI and Control UI consumers. flowchart LR
A[Installed plugin records] --> B[Shared metadata resolver]
C[Explicit authorized refresh] --> B
D[Package registries] --> B
B --> E[Retained availability observations]
E --> F[CLI inventory and status]
E --> G[Control UI notices]
Technical reviewBest possible solution: Accept or narrow one metadata-only availability contract that preserves sources and pins, exposes incomplete checks, and supplies consistent CLI and UI notices. Do we have a high-confidence way to reproduce the issue? A bug reproduction is not applicable: this PR adds a proposal, and its document verification makes no claim of exercising a future runtime implementation. Is this the best way to solve the issue? Reusing one metadata-only resolver while preserving install sources and pins is sound, but the proposed refresh interface and shared persistence need owner acceptance before implementation. AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning medium; reviewed against 967d9aac7472. TestingProof path: shipped entry point. SecurityNone. EvidenceWhat I checked:
Review metrics
LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment HistoryReview history (7 earlier review cycles)
Reviewed October 13, 2026, 1:54 AM ET / 05:54 UTC (Revision 8). |
|
@Patrick-Erichsen This goes with openclaw/openclaw#131897, not sure what I need to do here if anything. |
What Problem This Solves
Formalizes Erick Kinnee's proposal to surface installed-plugin update availability in CLI inventory, update status, and Control UI.
Related: openclaw/openclaw#131897
Why This Change Was Made
Proposes ClawHub as the primary metadata path while preserving recorded npm sources. Defines explicit plugin refresh, shared SQLite observation ownership, 24-hour freshness, four concurrent lookups, a 15-second network budget, and JSON distinctions for eligible, excluded, stale, and unknown results. Core upgrades invalidate cached eligibility. Metadata checks must not enter installer dry-run paths.
These defaults and persistence semantics are proposed for maintainer acceptance. Exact schema, migration, and publication fencing require storage-owner review before implementation. Upgrade preflight remains separate: openclaw/openclaw#122019.
User Impact
Proposal only; no runtime behavior changes. If accepted and implemented, operators could discover plugin updates while preserving pins and distinguishing incomplete checks.
Evidence
Document verification performed October 6, 2026 (America/Chicago; UTC timestamp below), against unchanged head
eb7d01d73d9555d1280b1ac5cae9d0c8b28d8607.The transcript below is the public reviewable evidence requested by ClawSweeper. It verifies the RFC document, not the future runtime implementation. Source: rendered RFC at the verified commit.
Method: extract the exact Git blob with
git show HEAD:rfcs/0065-plugin-update-availability.md; parse its frontmatter using PyYAML; compare metadata keys and H2 headings withrfcs/0000-template.mdat the base commit; render the body with markdown-it-py CommonMark and table support; parse the resulting HTML and compare heading/list counts to source; resolve every explicit document URL throughgh api; rungit diff --check BASE...HEAD. The SHA256 below identifies the exact extracted document bytes.A local HTML rendering was captured using headless Chrome at 1200×9000 and visually inspected. Heading hierarchy, bullets, inline code and both body links appear intact, with no visible clipping. The RFC contains no tables, diagrams, images or fenced blocks. The local screenshot and verification script are retained as task artifacts; the transcript is embedded here so public review does not depend on local filesystem access. This does not claim inspection of GitHub's rendered appearance. All three links resolved via authenticated GitHub REST reads; anonymous browser HTTP access was not tested.
Captured exact-commit document-verification transcript
Remaining acceptance gates
The RFC frontmatter remains
status: draftwith a blank implementationissue. The required maintainer-discussion thread and sponsorship, product acceptance or amendment of the v1 contract, and subsequent implementation issue remain outstanding. Acceptance must precede accepted frontmatter and merge, per the repository README. This PR's ready-for-review UI state is not RFC acceptance.Document verification cannot settle the proposed refresh/presentation contract, shared SQLite persistence, schema/migration/publication fencing, SDK compatibility or runtime behavior. Storage-owner and implementation review remain prerequisites. No runtime implementation, runtime proof, upgrade-compatibility verdict, RFC acceptance or merge is claimed.