Repository navigation
fix: refresh scanner worker trust dependencies - #4012
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. What this changesThis PR updates worker installations to Go 1.27.3, uv 0.13.4, and certifi 2026.10.19 while preserving scanner source pins and installation safeguards. Example: A fresh security worker installs the scanner resolver.
Review scores
ProductKind: Bug fix · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep this PR open: current main still selects affected trust dependencies, and this focused update has clear security value. No introduced blocking defects were found. Priority: P1 Before mergeNone. FindingsNone. Tests
Agent review detailsHow this fits togetherGitHub security workflows invoke shared installers that build the pinned ClawScan CLI and install its matching Python scanners; those tools produce evidence for publication and security review. flowchart TD
A[Security workflows] --> B[Shared installers]
B --> C[ClawScan Go binary]
B --> D[Python scanner environments]
C --> E[Security worker]
D --> E
E --> F[Scan evidence and verdicts]
Technical reviewBest possible solution: Update the existing installer pins while retaining scanner locks, source verification, operator CA settings, and separate ownership of deployment and remaining dependency repairs. Do we have a high-confidence way to reproduce the issue? Current-main pins and upstream advisories establish the affected default trust configuration without running target code; no exploit or worker runtime reproduction was performed during this review. Is this the best way to solve the issue? Best-fix verdict: best for the stated installer scope. Updating the existing dependency selections preserves reviewed source and lock contracts; changing scanner source revisions alone would not repair their separately locked dependencies. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 1c5fc5b72ef0. Provenance checked
TestingProof path: unit tests only. SecurityNone. EvidenceWhat I checked:
Likely related people:
Review metrics
LabelsLabel changes:
Label justifications:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 21, 2026, 3:59 AM ET / 07:59 UTC. |
What Problem This Solves
Security-worker installation selects older Go, uv, and AIG CA data that can trust chains involving the compromised eMudhra intermediates.
User Impact
Fresh worker installations consume released trust fixes: Go 1.27.3, uv 0.13.4 and certifi 2026.10.19. Existing workers require normal rebuild/reinstallation. This does not clear independently selected Node/Codex or SkillSpector dependencies.
Why This Change Was Made
Update the existing installer selections and only certifi's universal-wheel hash in the reviewed AIG environment. All scanner source commits, Responses patches, other Python pins and locked SkillSpector installation remain unchanged. SkillSpector's maintained lock still needs an upstream fix; updating its source ref alone would not repair it.
Evidence
git diff --checkpass.bun run ci:staticand all seven focused installer tests pass. The actual reviewed-source installer builds/runs ClawScan with Go 1.27.3. Static audit emits existing unrelated KaTeX/launch-editor advisory warnings. Full AIG installation targets Ubuntu amd64/macOS arm64 wheels; this Linux arm64 guest is outside its reviewed native-wheel hash set.Landing scope
Landing is explicitly authorized with the existing automatic main-merge effects: permanent Test deployment, configured Vercel frontend automation and subsequent ordinary worker runs. No manual production Convex, npm or GitHub release workflow is dispatched.