Skip to content

fix(security): update selected Node and scanner toolchains - #4015

Merged
joshavant merged 1 commit into
mainfrom
security/emudhra-node-release
Oct 22, 2026
Merged

joshavant merged 1 commit into
mainfrom
security/emudhra-node-release

Conversation

@joshavant

Copy link
Copy Markdown
Contributor

What Problem This Solves

Managed Node runtimes and the pinned ClawScan build source predate the incident trust fixes.

User Impact

CI selects fixed Node 22.23.4/24.22.1, the Endor image selects the fixed Node 22.23.4 base, and scanner installation builds the canonical incident-repaired ClawScan source.

Why This Change Was Made

Consume released Node patches and the already landed ClawScan repair through the existing build/install owners. Compatibility engine ranges remain unchanged.

Evidence

Isolated Linux arm64 latest stable Bun 1.4.3: required bun run ci:static passes. The actual install-clawscan.sh fetches the exact reviewed source, builds with Go 1.27.3 and completes a secretless CLI/static-scan smoke; embedded VCS identity matches the pin. Fresh P0–P3 full-source review, changed YAML and diff checks pass. Official Node image manifests and both architecture payload identities were verified; actual arm64 Node bytes match the qualified official release.

Existing nonblocking dependency-audit warnings remain in the evidence. Full Convex/browser/native image rebuild and deployed scanner delivery are separate proof/rollout work. Existing main-push permanent Test and configured frontend deployment effects remain; no deployment was performed here. Future merges require separate permission.

@joshavant
joshavant requested a review from a team as a code owner October 21, 2026 22:10
@vercel

vercel Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clawhub Ready Ready Preview Oct 21, 2026 10:15pm UTC

Request Review

@clawsweeper

clawsweeper Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper clawsweeper Bot added clawsweeper:intake:bug Preliminary submission classification; full source review pending. clawsweeper:intake:needs-repro Preliminary submission classification; full source review pending. P1 High-priority user-facing bug, regression, or broken workflow. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. and removed clawsweeper:intake:bug Preliminary submission classification; full source review pending. clawsweeper:intake:needs-repro Preliminary submission classification; full source review pending. labels Oct 21, 2026
@clawsweeper

clawsweeper Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs maintainer review before merge.

What this changes

Updates selected Node runtimes, the Endor base image, and the immutable ClawScan source revision.

Example: The Plugin Inspector bulk-scan workflow starts a scan.

  • Before: It selects Node 24.15.0.
  • After: It selects Node 24.22.1.

Review scores

Measure Result What it means
Overall readiness 🦐 gold shrimp (3/6) The patch is focused and source-supported, with passing exact-head checks; direct operational evidence for all selected toolchains remains limited.
Proof confidence 🦐 gold shrimp (3/6) The supplied maintainer-authored classification exempts the ordinary proof gate; the body reports an arm64 installer/static-scan smoke, while inspected upstream TLS diagnostics cover Claude rejection and private-CA controls rather than ClawHub Endor delivery.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Product

Kind: Maintenance · Worth it: Yes · Fix scope: Complete
User problem: Selected validation and scanning runtimes lack released security repairs.
Reason: The supplied maintainer-authored classification establishes direction, and the small update preserves existing runtime majors, scanner contracts, and rollout owners.

Merge readiness

✅ Ready for maintainer review

Keep this PR open: current main still selects the older toolchains, and this focused security update has no actionable findings.

Priority: P1
Reviewed head: cfc643f508202b0e02de7f8b4ede3cc59f94bd7e

Before merge

None.

Findings

None.

Tests

  • Missing end-to-end proof: Direct output from this PR's updated Endor image and scanner installation is not attached; the supplied maintainer classification exempts ordinary contributor proof.
Agent review details

How this fits together

Workflow and installer pins select the runtimes used by CI, release tooling, and security scanners; these produce validation results, release artifacts, and scan evidence.

flowchart TD
  A[Repository toolchain pins] --> B[CI and release workflows]
  A --> C[ClawScan source installer]
  A --> D[Endor image build]
  B --> E[Validation and release artifacts]
  C --> F[Security scan evidence]
  D --> F
Loading

Technical review

Best possible solution:

Adopt the patched selections through the existing installers and workflows, with scanner image delivery handled through their established rollout paths.

Do we have a high-confidence way to reproduce the issue?

Current main visibly selects older Node and ClawScan revisions, and official upstream releases establish the relevant repairs; no exploit or target runtime was executed during this review.

Is this the best way to solve the issue?

This is the best bounded fix: update the existing selection owners rather than duplicate upstream trust logic or change compatibility engine ranges.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 6e6c57d1b681.

Provenance checked

  • CI and Plugin Inspector Node selection keeps the original intent (fa653d4: Prior compatibility work selected supported Node 24 runtimes; the newer patch remains within that contract.)
  • CLI release workflow Node selection changes intended behavior with a stated reason (65bc5d3: Guarded release workflows selected Node 24; this PR explicitly selects the released security patch instead of the floating major.)
  • Developer Node major changes intended behavior with a stated reason (2fd0aa0: The existing developer pin selected Node 22; the PR retains that major while making its patched version explicit.)
  • ClawScan source lock keeps the original intent (ffaceac: The previous lock adopted exact-manifest inspection receipt guidance; the upstream comparison confirms that guidance remains present.)
  • Endor container base keeps the original intent (5e8aec5: The Endor integration uses an isolated Node 22 Bookworm image; the update preserves that boundary and digest pinning.)

Testing

Proof path: unit tests only.

Security

None.

Evidence

What I checked:

Likely related people:

  • Peter Steinberger: Raw commit 24f4d42 adds .github/workflows/plugin-inspector-bulk-scan.yml:70 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 24f4d4218b22; files: .github/workflows/plugin-inspector-bulk-scan.yml)
  • Gio Della-Libera: Raw commit 5a3b050 adds .github/workflows/ci.yml:66 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: medium; commits: 5a3b050751f7; files: .github/workflows/ci.yml)

Review metrics

Metric Value Why it matters
Patch size +8/-8 across 7 configuration files The update reuses existing installation owners without adding production machinery or test scaffolding.

Labels

Label changes:

  • add P1: Owned CI and scanner selections predate released certificate-trust and other security repairs.
  • add rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Label justifications:

  • P1: Owned CI and scanner selections predate released certificate-trust and other security repairs.
  • rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed October 21, 2026, 6:24 PM ET / 22:24 UTC.

@joshavant
joshavant merged commit d7eb38e into main Oct 22, 2026
74 of 76 checks passed
@joshavant
joshavant deleted the security/emudhra-node-release branch October 22, 2026 17:15

This branch was successfully deployed

1 active deployment
Preview – clawhub — cfc643f5 Deployed Oct 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P1 High-priority user-facing bug, regression, or broken workflow. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant