Repository navigation
fix(security): update selected Node and scanner toolchains - #4015
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. What this changesUpdates selected Node runtimes, the Endor base image, and the immutable ClawScan source revision. Example: The Plugin Inspector bulk-scan workflow starts a scan.
Review scores
ProductKind: Maintenance · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep this PR open: current main still selects the older toolchains, and this focused security update has no actionable findings. Priority: P1 Before mergeNone. FindingsNone. Tests
Agent review detailsHow this fits togetherWorkflow and installer pins select the runtimes used by CI, release tooling, and security scanners; these produce validation results, release artifacts, and scan evidence. flowchart TD
A[Repository toolchain pins] --> B[CI and release workflows]
A --> C[ClawScan source installer]
A --> D[Endor image build]
B --> E[Validation and release artifacts]
C --> F[Security scan evidence]
D --> F
Technical reviewBest possible solution: Adopt the patched selections through the existing installers and workflows, with scanner image delivery handled through their established rollout paths. Do we have a high-confidence way to reproduce the issue? Current main visibly selects older Node and ClawScan revisions, and official upstream releases establish the relevant repairs; no exploit or target runtime was executed during this review. Is this the best way to solve the issue? This is the best bounded fix: update the existing selection owners rather than duplicate upstream trust logic or change compatibility engine ranges. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 6e6c57d1b681. Provenance checked
TestingProof path: unit tests only. SecurityNone. EvidenceWhat I checked:
Likely related people:
Review metrics
LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 21, 2026, 6:24 PM ET / 22:24 UTC. |
What Problem This Solves
Managed Node runtimes and the pinned ClawScan build source predate the incident trust fixes.
User Impact
CI selects fixed Node 22.23.4/24.22.1, the Endor image selects the fixed Node 22.23.4 base, and scanner installation builds the canonical incident-repaired ClawScan source.
Why This Change Was Made
Consume released Node patches and the already landed ClawScan repair through the existing build/install owners. Compatibility engine ranges remain unchanged.
Evidence
Isolated Linux arm64 latest stable Bun 1.4.3: required
bun run ci:staticpasses. The actualinstall-clawscan.shfetches the exact reviewed source, builds with Go 1.27.3 and completes a secretless CLI/static-scan smoke; embedded VCS identity matches the pin. Fresh P0–P3 full-source review, changed YAML and diff checks pass. Official Node image manifests and both architecture payload identities were verified; actual arm64 Node bytes match the qualified official release.Existing nonblocking dependency-audit warnings remain in the evidence. Full Convex/browser/native image rebuild and deployed scanner delivery are separate proof/rollout work. Existing main-push permanent Test and configured frontend deployment effects remain; no deployment was performed here. Future merges require separate permission.