Repository navigation
refactor(plugin): preserve Windows filenames in native helpers - #798
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
98e64e2 to
f5bfd66
Compare
f5bfd66 to
0f1995a
Compare
0f1995a to
08a2ac5
Compare
08a2ac5 to
6014da9
Compare
mldangelo-oai
left a comment
There was a problem hiding this comment.
Re-reviewed the exact current head after the latest fixes. The four earlier threads are resolved. I found one remaining Windows path correctness bug and two nonblocking simplifications.
6014da9 to
c58c6d0
Compare
c58c6d0 to
b3609d5
Compare
b3609d5 to
d8951fc
Compare
mldangelo-oai
left a comment
There was a problem hiding this comment.
Re-reviewed exact head d8951fc. Recursive directory creation is now one std::fs::create_dir_all call through the native error adapter. The retained empty-path branch is justified by pinned Rust 1.97 rejecting empty input before Win32, with LastError cleared before the compatibility call. All prior threads are resolved and all required checks pass.
d8951fc to
033fffc
Compare
033fffc to
6a08023
Compare
6a08023 to
19c5fae
Compare
19c5fae to
cdabf01
Compare
cdabf01 to
cd81a21
Compare
cd81a21 to
ec4dd08
Compare
Summary
Preserve Windows filenames when replacing Python path handling with TypeScript. Helpers receive original UTF-16 arguments, environment values, directory names, and paths, including lone surrogates.
Changes
std::fs::read_dirand cached entry types for one typed directory enumerator, preserving raw names and numeric Windows errors.std::path::absolute, preserving native errors and the existing empty-input result. Normalize verbatim paths below their drive or share root, including doubled separators and parent traversal.create_dir_allfor recursive directory creation. Retain raw process-value transport.Testing
Risk and rollout
Stacked on #797. Adds native operations without changing command routing or public CLI syntax. Junction directory entries now carry Rust's directory and symbolic-link flags; the following resolver still excludes their traversal. Sharing restrictions do not block attribute-only requests, so the proof checks a data read without changing product stat access.
Public disclosure review